minor

Author: vicb

benchmark/lexer_perf.dart

@@ -5,16 +5,10 @@ import 'package:angular/core/parser/lexer.dart';
 
 main() {
   Lexer lexer = new Lexer();
-  time('ident', () =>
-      lexer.call('ctrl foo baz ctrl.foo ctrl.bar ctrl.baz'));
-  time('ident-path', () =>
-      lexer.call('a.b a.b.c a.b.c.d a.b.c.d.e.f'));
-  time('num', () =>
-      lexer.call('1 23 34 456 12341234 12351235'));
-  time('num-double', () =>
-      lexer.call('.0 .1 .12 0.123 0.1234'));
-  time('string', () =>
-      lexer.call("'quick brown dog and fox say what'"));
-  time('string-escapes', () =>
-      lexer.call("quick '\\' brown \u1234 dog and fox\n\rsay what'"));
+  time('ident', () => lexer.call('ctrl foo baz ctrl.foo ctrl.bar ctrl.baz'));
+  time('ident-path', () => lexer.call('a.b a.b.c a.b.c.d a.b.c.d.e.f'));
+  time('num', () => lexer.call('1 23 34 456 12341234 12351235'));
+  time('num-double', () => lexer.call('.0 .1 .12 0.123 0.1234'));
+  time('string', () => lexer.call("'quick brown dog and fox say what'"));
+  time('string-escapes', () => lexer.call("quick '\\' brown \u1234 dog and fox\n\rsay what'"));
 }

lib/animate/module.dart

@@ -4,27 +4,26 @@
  * The [angular.animate](#angular/angular-animate) library makes it easier to build animations
  * that affect the lifecycle of DOM elements. A useful example of this is animating the
  * removal of an element from the DOM. In order to do this ideally the
- * operation should immediatly execute and manipulate the data model,
+ * operation should immediately execute and manipulate the data model,
  * and the framework should handle the actual remove of the DOM element once
- * the animation complets. This ensures that the logic and model of the
- * application is seperated so that the state of the model can be reasoned
- * about without having to wory about future modifications of the model.
+ * the animation completes. This ensures that the logic and model of the
+ * application is separated so that the state of the model can be reasoned
+ * about without having to worry about future modifications of the model.
  * This library uses computed css styles to calculate the total duration
  * of an animation and handles the addition, removal, and modification of DOM
  * elements for block level directives such as `ng-if`, `ng-repeat`,
  * `ng-hide`, and more.
  *
  * To use, install the AnimationModule into your main module:
  *
- *     var module = new Module()
- *       ..install(new AnimationModule());
+ *     var module = new Module()..install(new AnimationModule());
  *
  * Once the module has been installed, all block level DOM manipulations will
  * be routed through the [CssAnimate] class instead of the
  * default [NgAnimate] implementation. This will, in turn,
  * perform the tracking, manipulation, and computation for animations.
  *
- * As an example of how this works, let's walk through what happens whan an
+ * As an example of how this works, let's walk through what happens when an
  * element is added to the DOM. The [CssAnimate] implementation will add the
  * `.ng-enter` class to new DOM elements when they are inserted into the DOM
  * by a directive and will read the computed style. If there is a
@@ -35,7 +34,7 @@
  * precomputed duration) the `.ng-enter` and `.ng-enter-active` classes
  * will be removed from the DOM element.
  *
- * When removing elements from the DOM, a simliar pattern is followed. The
+ * When removing elements from the DOM, a similar pattern is followed. The
  * `.ng-leave` class will be added to an element, the transition and / or
  * keyframe animation duration will be computed, and if it is non-zero the
  * animation will be run by adding the `.ng-leave-active` class. When
@@ -58,7 +57,7 @@
  * Fade out example:
  *
  * HTML:
- *     <div class="goodbye" ng-if="ctrl.visible">
+ *     <div class="goodbye" ng-if="visible">
  *       Goodbye world!
  *     </div>
  *
@@ -71,8 +70,8 @@
  *       opacity: 0;
  *     }
  *
- * This will perform a fade out animation on the 'goodby' div when the
- * `ctrl.visible` property goes from `true` to `false`.
+ * This will perform a fade out animation on the 'goodbye' div when the
+ * `visible` property goes from `true` to `false`.
  *
  * The [CssAnimate] will also do optimizations on running animations by
  * preventing child DOM animations with the [AnimationOptimizer]. This
@@ -129,11 +128,11 @@ final Logger _logger = new Logger('ng.animate');
  * of view construction, and some of the native directives to allow you to add
  * and define css transition and keyframe animations for the styles of your
  * elements.
- * 
+ *
  *   Example html:
  *
  *     <div ng-if="ctrl.myBoolean" class="my-div">...</div>
- *   
+ *
  *   Example css defining an opacity transition over .5 seconds using the
  *   `.ng-enter` and `.ng-leave` css classes:
  *
@@ -144,7 +143,7 @@ final Logger _logger = new Logger('ng.animate');
  *     .my-div.ng-enter-active {
  *       opacity: 1;
  *     }
- *     
+ *
  *     .my-div.ng-leave {
  *       transition: all 500ms;
  *       opacity: 1;

lib/core_dom/event_handler.dart

@@ -4,7 +4,7 @@ typedef void EventFunction(event);
 
 /**
  * [EventHandler] is responsible for handling events bound using on-* syntax
- * (i.e. `on-click="ctrl.doSomething();"`). The root of the application has an
+ * (i.e. `on-click="doSomething();"`). The root of the application has an
  * EventHandler attached as does every [Component].
  *
  * Events bound within [Component] are handled by EventHandler attached to
@@ -16,12 +16,14 @@ typedef void EventFunction(event);
  * Example:
  *
  *     <div foo>
- *       <button on-click="ctrl.say('Hello');">Button</button>;
+ *       <button on-click="say('Hello');">Button</button>;
  *     </div>
  *
- *     @Component(selector: '[foo]', publishAs: ctrl)
+ *     @Component(selector: '[foo]')
  *     class FooController {
- *       say(String something) => print(something);
+ *       void say(String something) {
+ *         print(something);
+ *       }
  *     }
  *
  * When button is clicked, "Hello" will be printed in the console.

lib/core_dom/transcluding_component_factory.dart

@@ -1,7 +1,6 @@
 part of angular.core.dom_internal;
 
-@Decorator(
-   selector: 'content')
+@Decorator(selector: 'content')
 class Content implements AttachAware, DetachAware {
   final ContentPort _port;
   final dom.Element _element;
@@ -12,7 +11,7 @@ class Content implements AttachAware, DetachAware {
     if (_port == null) return;
     _beginComment = _port.content(_element);
   }
-  
+
   void detach() {
     if (_port == null) return;
     _port.detachContent(_beginComment);
@@ -21,24 +20,24 @@ class Content implements AttachAware, DetachAware {
 
 class ContentPort {
   dom.Element _element;
-  var _childNodes = [];
+  final _childNodes = <dom.Node>[];
 
   ContentPort(this._element);
 
   void pullNodes() {
     _childNodes.addAll(_element.nodes);
-    _element.nodes = [];
+    _element.nodes.clear();
   }
 
-  content(dom.Element elt) {
+  dom.Comment content(dom.Element elt) {
     var hash = elt.hashCode;
     var beginComment = new dom.Comment("content $hash");
 
     if (_childNodes.isNotEmpty) {
       elt.parent.insertBefore(beginComment, elt);
       elt.parent.insertAllBefore(_childNodes, elt);
       elt.parent.insertBefore(new dom.Comment("end-content $hash"), elt);
-      _childNodes = [];
+      _childNodes.clear();
     }
     elt.remove();
     return beginComment;

lib/directive/module.dart

@@ -12,7 +12,7 @@
  *
  * For example:
  *
- *     <span ng-show="ctrl.isVisible">this text is conditionally visible</span>
+ *     <span ng-show="isVisible">this text is conditionally visible</span>
  *
  */
 library angular.directive;

lib/directive/ng_if.dart

@@ -1,7 +1,7 @@
 part of angular.directive;
 
 /**
- * Base class for NgIf and NgUnless.
+ * Base class for [NgIf] and [NgUnless].
  */
 abstract class _NgUnlessIfAttrDirectiveBase {
   final BoundViewFactory _boundViewFactory;