Fixed changes request

Author: Costin Bleotu

.drone.yml

@@ -291,16 +291,16 @@ def hook_type(self):
         @property
         def events(self):
             """
-            The events that fires the hook
+            The events that fire the hook
 
-            :rtype: list of strs
+            :rtype: List[str]
             """
             return self._events
 
         @property
         def active(self):
             """
-            State of the hook
+            Whether the hook is active
 
             :rtype: bool
             """
@@ -397,7 +397,7 @@ def created_at(self):
         @property
         def read_only(self):
             """
-            Is the key read only?
+            Whether key is read-only.
             :rtype: bool
             """
             return self._read_only
@@ -454,7 +454,7 @@ def username(self):
         """
         Organization's username
 
-        :rtype: int
+        :rtype: str
         """
         return self._username
 
@@ -463,7 +463,7 @@ def full_name(self):
         """
         Organization's full name
 
-        :rtype: int
+        :rtype: str
         """
         return self._full_name 
 
@@ -544,7 +544,7 @@ def name(self):
             """
             Team name
 
-            :rtype: int
+            :rtype: str
             """
             return self._name
 
@@ -553,7 +553,7 @@ def description(self):
             """
             Description to the team
 
-            :rtype: int
+            :rtype: str
             """
             return self._description
 

gogs_client/entities.py

@@ -420,7 +420,6 @@ def delete_hook(self, auth, username, repo_name, hook_id):
         """
         path = "/repos/{u}/{r}/hooks/{i}".format(u=username, r=repo_name, i=hook_id)
         response = self._check_ok(self._delete(path, auth=auth))
-        return response
 
     def create_organization(self, auth, username, org_name, full_name=None, avatar_url=None, description=None, website=None, location=None):
         """
@@ -457,7 +456,7 @@ def create_organization_team(self, auth, org_name, name, description=None, permi
 
         :param auth.Authentication auth: authentication object, must be admin-level
         :param str org_name: [Required] Organization user name
-        :param str team_name: Full name of the team
+        :param str name: Full name of the team
         :param str description: Description to the team
         :param str permission: Team permission, can be read, write or admin, default is read
         :return: a representation of the created team
@@ -484,14 +483,11 @@ def add_team_membership(self, auth, team_id, username):
         :param auth.Authentication auth: authentication object, must be admin-level
         :param str team_id: [Required] Id of the team
         :param str username: Username of the user to be added to team
-        :return: status code of the request
-        :rtype: str
         :raises NetworkFailure: if there is an error communicating with the server
         :raises ApiFailure: if the request cannot be serviced
         """
         url = "/admin/teams/{t}/members/{u}".format(t=team_id, u=username) 
-        response = self._put(url, auth=auth)
-        return self._check_ok(response)
+        response = self._check_ok(self._put(url, auth=auth))
 
     def remove_team_membership(self, auth, team_id, username):
         """
@@ -500,14 +496,11 @@ def remove_team_membership(self, auth, team_id, username):
         :param auth.Authentication auth: authentication object, must be admin-level
         :param str team_id: [Required] Id of the team
         :param str username: Username of the user to be removed from the team
-        :return: status code of the request
-        :rtype: str
         :raises NetworkFailure: if there is an error communicating with the server
         :raises ApiFailure: if the request cannot be serviced
         """
         url = "/admin/teams/{t}/members/{u}".format(t=team_id, u=username) 
-        response = self._delete(url, auth=auth)
-        return self._check_ok(response)
+        response = self._check_ok(self._delete(url, auth=auth))
 
     def add_repo_to_team(self, auth, team_id, repo_name):
         """
@@ -516,15 +509,11 @@ def add_repo_to_team(self, auth, team_id, repo_name):
         :param auth.Authentication auth: authentication object, must be admin-level
         :param str team_id: [Required] Id of the team
         :param str repo_name: Name of the repo to be added to the team
-        :return: status code of the request
-        :rtype: str
         :raises NetworkFailure: if there is an error communicating with the server
         :raises ApiFailure: if the request cannot be serviced
         """
         url = "/admin/teams/{t}/repos/{r}".format(t=team_id, r=repo_name) 
-        response = self._put(url, auth=auth)
-        return self._check_ok(response)
-
+        response = self._check_ok(self._put(url, auth=auth))
 
     def remove_repo_from_team(self, auth, team_id, repo_name):
         """
@@ -533,14 +522,11 @@ def remove_repo_from_team(self, auth, team_id, repo_name):
         :param auth.Authentication auth: authentication object, must be admin-level
         :param str team_id: [Required] Id of the team
         :param str repo_name: Name of the repo to be removed from the team
-        :return: status code of the request
-        :rtype: str
         :raises NetworkFailure: if there is an error communicating with the server
         :raises ApiFailure: if the request cannot be serviced
         """
         url = "/admin/teams/{t}/repos/{r}".format(t=team_id, r=repo_name) 
-        response = self._delete(url, auth=auth)
-        return self._check_ok(response)
+        response = self._check_ok(self._delete(url, auth=auth))
 
     def list_deploy_keys(self, auth, username, repo_name):
         """

gogs_client/interface.py

@@ -458,7 +458,7 @@ def test_delete_hook(self):
         uri = self.path("/repos/username/repo1/hooks/4")
         responses.add(responses.DELETE, uri, status=204)
         hook = self.client.delete_hook(self.token, "username", "repo1", 4)
-        self.assertEqual(hook.status_code, 204)
+        self.assertEqual(hook, None)
 
     @responses.activate
     def test_create_organization(self):
@@ -495,28 +495,28 @@ def test_add_team_membership(self):
         uri = self.path("/admin/teams/team/members/username")
         responses.add(responses.PUT, uri, status=204)
         resp = self.client.add_team_membership(self.token, "team", "username")
-        self.assertEqual(resp.status_code, 204)
+        self.assertEqual(resp, None)
 
     @responses.activate
     def test_remove_team_membership(self):
         uri = self.path("/admin/teams/team/members/username")
         responses.add(responses.DELETE, uri, status=204)
         resp = self.client.remove_team_membership(self.token, "team", "username")
-        self.assertEqual(resp.status_code, 204)
+        self.assertEqual(resp, None)
 
     @responses.activate
     def test_add_repo_to_team(self):
         uri = self.path("/admin/teams/test_team/repos/repo_name")
         responses.add(responses.PUT, uri, status=204)
         resp = self.client.add_repo_to_team(self.token, "test_team", "repo_name")
-        self.assertEqual(resp.status_code, 204)
+        self.assertEqual(resp, None)
 
     @responses.activate
     def test_remove_repo_from_team(self):
         uri = self.path("/admin/teams/test_team/repos/repo_name")
         responses.add(responses.DELETE, uri, status=204)
         resp = self.client.remove_repo_from_team(self.token, "test_team", "repo_name")
-        self.assertEqual(resp.status_code, 204)
+        self.assertEqual(resp, None)
 
     @responses.activate
     def test_list_deploy_keys(self):