Skip to content

Commit d02992c

Browse files
committed
bump to latest windows-sdk and document better
1 parent 274527a commit d02992c

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

.github/workflows/publish-go-nightly-task.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,10 @@ jobs:
172172

173173
env:
174174
INSTALLER_CERT_WINDOWS_PFX: "/tmp/cert.pfx"
175-
SIGNTOOL_PATH: "C:/Program Files (x86)/Windows Kits/10/bin/10.0.17763.0/x86/signtool.exe"
175+
# We are hardcoding the path for signtool because is not present on the windows PATH env var by default.
176+
# Keep in mind that this path could change when upgrading to a new runner version
177+
# https://github.com/actions/runner-images/blob/main/images/win/Windows2022-Readme.md#installed-windows-sdks
178+
SIGNTOOL_PATH: "C:/Program Files (x86)/Windows Kits/10/bin/10.0.22621.0/x86/signtool.exe"
176179

177180
steps:
178181
- name: Checkout repository

.github/workflows/release-go-task.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,10 @@ jobs:
179179

180180
env:
181181
INSTALLER_CERT_WINDOWS_PFX: "/tmp/cert.pfx"
182-
SIGNTOOL_PATH: "C:/Program Files (x86)/Windows Kits/10/bin/10.0.17763.0/x86/signtool.exe"
182+
# We are hardcoding the path for signtool because is not present on the windows PATH env var by default.
183+
# Keep in mind that this path could change when upgrading to a new runner version
184+
# https://github.com/actions/runner-images/blob/main/images/win/Windows2022-Readme.md#installed-windows-sdks
185+
SIGNTOOL_PATH: "C:/Program Files (x86)/Windows Kits/10/bin/10.0.22621.0/x86/signtool.exe"
183186

184187
steps:
185188
- name: Checkout repository

0 commit comments

Comments
 (0)