Skip to content

Commit c8ef9a6

Browse files
committed
remove subtle diffs
1 parent 5cc0b10 commit c8ef9a6

File tree

3 files changed

+19
-6
lines changed

3 files changed

+19
-6
lines changed

build/diff.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,10 @@ async function main() {
2323
const libFiles = await getLibFiles();
2424
const hasDiffFiles: string[] = [];
2525
for (const [targetFile, sourceFile] of libFiles.entries()) {
26-
const betterLib = generate(tsLibDir, targetFile, sourceFile, false);
26+
const betterLib = generate(tsLibDir, targetFile, sourceFile, {
27+
emitOriginalAsComment: false,
28+
emitNoDefaultLib: false,
29+
});
2730
if (betterLib === undefined) {
2831
continue;
2932
}

build/lib.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,10 @@ async function main() {
2121

2222
// modify each lib file
2323
for (const [targetFile, sourceFile] of libFiles.entries()) {
24-
let result = generate(tsLibDir, targetFile, sourceFile, true);
24+
let result = generate(tsLibDir, targetFile, sourceFile, {
25+
emitOriginalAsComment: true,
26+
emitNoDefaultLib: true,
27+
});
2528
if (result === undefined) {
2629
continue;
2730
}

build/logic/generate.ts

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,19 @@ import { projectDir } from "./projectDir";
66

77
const betterLibDir = path.join(projectDir, "lib");
88

9+
type GenerateOptions = {
10+
emitOriginalAsComment?: boolean;
11+
emitNoDefaultLib?: boolean;
12+
};
13+
914
/**
1015
* Generate one better lib file.
1116
*/
1217
export function generate(
1318
tsLibDir: string,
1419
targetFile: string,
1520
sourceFile: string,
16-
emitOriginalAsComment: boolean
21+
{ emitOriginalAsComment = false, emitNoDefaultLib = false }: GenerateOptions
1722
): string | undefined {
1823
const tsLibFile = path.join(tsLibDir, sourceFile);
1924
const originalProgram = ts.createProgram([tsLibFile], {});
@@ -24,9 +29,11 @@ export function generate(
2429

2530
const printer = ts.createPrinter();
2631

27-
// This is used as a good indicator of being a default lib file
28-
let result = `/// <reference no-default-lib="true"/>
29-
`;
32+
let result = emitNoDefaultLib
33+
? // This is used as a good indicator of being a default lib file
34+
`/// <reference no-default-lib="true"/>
35+
`
36+
: "";
3037

3138
const replacementTargets = scanBetterFile(printer, targetFile);
3239

0 commit comments

Comments
 (0)