From a046adb168733fb6cd8574cfac89481d4cb1f186 Mon Sep 17 00:00:00 2001 From: KingDarBoja Date: Sat, 6 Mar 2021 17:08:58 -0500 Subject: [PATCH] Fix codelyzer template-conditional-complexity converter Was missing the "maxComplexity" property at the output rule --- .../template-conditional-complexity.ts | 9 ++++++++- .../template-conditional-complexity.test.ts | 20 +++++++++++++++++++ 2 files changed, 28 insertions(+), 1 deletion(-) diff --git a/src/converters/lintConfigs/rules/ruleConverters/codelyzer/template-conditional-complexity.ts b/src/converters/lintConfigs/rules/ruleConverters/codelyzer/template-conditional-complexity.ts index b628dbe3a..d1801cf62 100644 --- a/src/converters/lintConfigs/rules/ruleConverters/codelyzer/template-conditional-complexity.ts +++ b/src/converters/lintConfigs/rules/ruleConverters/codelyzer/template-conditional-complexity.ts @@ -1,9 +1,16 @@ import { RuleConverter } from "../../ruleConverter"; -export const convertTemplateConditionalComplexity: RuleConverter = () => { +export const convertTemplateConditionalComplexity: RuleConverter = (tslintRule) => { return { rules: [ { + ...(tslintRule.ruleArguments.length === 1 && { + ruleArguments: [ + { + maxComplexity: tslintRule.ruleArguments[0], + }, + ], + }), ruleName: "@angular-eslint/template/conditional-complexity", }, ], diff --git a/src/converters/lintConfigs/rules/ruleConverters/codelyzer/tests/template-conditional-complexity.test.ts b/src/converters/lintConfigs/rules/ruleConverters/codelyzer/tests/template-conditional-complexity.test.ts index a1de7c01b..a2a9c9746 100644 --- a/src/converters/lintConfigs/rules/ruleConverters/codelyzer/tests/template-conditional-complexity.test.ts +++ b/src/converters/lintConfigs/rules/ruleConverters/codelyzer/tests/template-conditional-complexity.test.ts @@ -15,4 +15,24 @@ describe(convertTemplateConditionalComplexity, () => { plugins: ["@angular-eslint/eslint-plugin-template"], }); }); + + test("conversion with arguments", () => { + const result = convertTemplateConditionalComplexity({ + ruleArguments: [4], + }); + + expect(result).toEqual({ + rules: [ + { + ruleArguments: [ + { + maxComplexity: 4, + }, + ], + ruleName: "@angular-eslint/template/conditional-complexity", + }, + ], + plugins: ["@angular-eslint/eslint-plugin-template"], + }); + }); });