From eb47ecb741a75c881e5045109acbf5b619648ba3 Mon Sep 17 00:00:00 2001 From: Josh Goldberg Date: Tue, 8 Sep 2020 00:35:09 -0400 Subject: [PATCH] Added missing output plugins to configuration file --- src/creation/writeConversionResults.test.ts | 7 ++++++- src/creation/writeConversionResults.ts | 6 +++--- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/src/creation/writeConversionResults.test.ts b/src/creation/writeConversionResults.test.ts index 93c2f9760..3f21d7a4a 100644 --- a/src/creation/writeConversionResults.test.ts +++ b/src/creation/writeConversionResults.test.ts @@ -60,6 +60,7 @@ describe("writeConversionResults", () => { ruleSeverity: "error", }, ], + plugins: new Set(["eslint-plugin-example"]), }); const fileSystem = { writeFile: jest.fn().mockReturnValue(Promise.resolve()) }; @@ -85,7 +86,11 @@ describe("writeConversionResults", () => { project: "tsconfig.json", sourceType: "module", }, - plugins: ["@typescript-eslint", "@typescript-eslint/tslint"], + plugins: [ + "eslint-plugin-example", + "@typescript-eslint", + "@typescript-eslint/tslint", + ], rules: { "@typescript-eslint/tslint/config": [ "error", diff --git a/src/creation/writeConversionResults.ts b/src/creation/writeConversionResults.ts index 088df2c94..0d1823939 100644 --- a/src/creation/writeConversionResults.ts +++ b/src/creation/writeConversionResults.ts @@ -16,11 +16,11 @@ export const writeConversionResults = async ( summarizedResults: SummarizedResultsConfiguration, originalConfigurations: AllOriginalConfigurations, ) => { - const plugins = ["@typescript-eslint"]; + const plugins = new Set([...summarizedResults.plugins, "@typescript-eslint"]); const { eslint, tslint } = originalConfigurations; if (summarizedResults.missing.length !== 0) { - plugins.push("@typescript-eslint/tslint"); + plugins.add("@typescript-eslint/tslint"); } const output = removeEmptyMembers({ @@ -33,7 +33,7 @@ export const writeConversionResults = async ( project: "tsconfig.json", sourceType: "module", }, - plugins, + plugins: Array.from(plugins), rules: formatConvertedRules(summarizedResults, tslint.full), });