From 4059050c0c182101f7d956db3a7dcbbb19526e46 Mon Sep 17 00:00:00 2001 From: KingDarBoja Date: Fri, 17 Jul 2020 21:25:38 -0500 Subject: [PATCH 1/2] Added jsx-key converter --- .../converters/eslint-plugin-react/jsx-key.ts | 13 +++++++++++++ .../eslint-plugin-react/tests/jsx-key.test.ts | 19 +++++++++++++++++++ src/rules/rulesConverters.ts | 2 ++ 3 files changed, 34 insertions(+) create mode 100644 src/rules/converters/eslint-plugin-react/jsx-key.ts create mode 100644 src/rules/converters/eslint-plugin-react/tests/jsx-key.test.ts diff --git a/src/rules/converters/eslint-plugin-react/jsx-key.ts b/src/rules/converters/eslint-plugin-react/jsx-key.ts new file mode 100644 index 000000000..904a61276 --- /dev/null +++ b/src/rules/converters/eslint-plugin-react/jsx-key.ts @@ -0,0 +1,13 @@ +import { RuleConverter } from "../../converter"; + +export const convertJsxKey: RuleConverter = () => { + return { + rules: [ + { + ruleName: "react/jsx-key", + ruleArguments: [""], + }, + ], + plugins: ["eslint-plugin-react"], + }; +}; diff --git a/src/rules/converters/eslint-plugin-react/tests/jsx-key.test.ts b/src/rules/converters/eslint-plugin-react/tests/jsx-key.test.ts new file mode 100644 index 000000000..2e1355552 --- /dev/null +++ b/src/rules/converters/eslint-plugin-react/tests/jsx-key.test.ts @@ -0,0 +1,19 @@ +import { convertJsxKey } from "../jsx-key"; + +describe(convertJsxKey, () => { + test("conversion without arguments", () => { + const result = convertJsxKey({ + ruleArguments: [], + }); + + expect(result).toEqual({ + rules: [ + { + ruleName: "react/jsx-key", + ruleArguments: [""], + }, + ], + plugins: ["eslint-plugin-react"], + }); + }); +}); diff --git a/src/rules/rulesConverters.ts b/src/rules/rulesConverters.ts index 6e7423df3..dea85eeb7 100644 --- a/src/rules/rulesConverters.ts +++ b/src/rules/rulesConverters.ts @@ -174,6 +174,7 @@ import { convertUsePipeTransformInterface } from "./converters/codelyzer/use-pip // ESLint-React converters import { convertJsxBooleanValue } from "./converters/eslint-plugin-react/jsx-boolean-value"; +import { convertJsxKey } from "./converters/eslint-plugin-react/jsx-key"; /** * Keys TSLint rule names to their ESLint rule converters. @@ -212,6 +213,7 @@ export const rulesConverters = new Map([ ["interface-over-type-literal", convertInterfaceOverTypeLiteral], ["jsdoc-format", convertJSDocFormat], ["jsx-boolean-value", convertJsxBooleanValue], + ["jsx-key", convertJsxKey], ["label-position", convertLabelPosition], ["linebreak-style", convertLinebreakStyle], ["max-classes-per-file", convertMaxClassesPerFile], From 8e6a307c258f3511ae47d24bffb1e139aed690bb Mon Sep 17 00:00:00 2001 From: KingDarBoja Date: Sat, 18 Jul 2020 10:20:33 -0500 Subject: [PATCH 2/2] Remove ruleArguments in jsx-key converter --- src/rules/converters/eslint-plugin-react/jsx-key.ts | 1 - src/rules/converters/eslint-plugin-react/tests/jsx-key.test.ts | 1 - 2 files changed, 2 deletions(-) diff --git a/src/rules/converters/eslint-plugin-react/jsx-key.ts b/src/rules/converters/eslint-plugin-react/jsx-key.ts index 904a61276..bf619103c 100644 --- a/src/rules/converters/eslint-plugin-react/jsx-key.ts +++ b/src/rules/converters/eslint-plugin-react/jsx-key.ts @@ -5,7 +5,6 @@ export const convertJsxKey: RuleConverter = () => { rules: [ { ruleName: "react/jsx-key", - ruleArguments: [""], }, ], plugins: ["eslint-plugin-react"], diff --git a/src/rules/converters/eslint-plugin-react/tests/jsx-key.test.ts b/src/rules/converters/eslint-plugin-react/tests/jsx-key.test.ts index 2e1355552..8a80048d3 100644 --- a/src/rules/converters/eslint-plugin-react/tests/jsx-key.test.ts +++ b/src/rules/converters/eslint-plugin-react/tests/jsx-key.test.ts @@ -10,7 +10,6 @@ describe(convertJsxKey, () => { rules: [ { ruleName: "react/jsx-key", - ruleArguments: [""], }, ], plugins: ["eslint-plugin-react"],