From 1941e9c8f1521be46b64ff1f54fc0741949c9450 Mon Sep 17 00:00:00 2001 From: KingDarBoja Date: Sat, 9 May 2020 14:50:55 -0500 Subject: [PATCH] Add codelyzer no-forward-ref converter --- .../converters/codelyzer/no-forward-ref.ts | 12 ++++++++++++ .../codelyzer/tests/no-forward-ref.test.ts | 18 ++++++++++++++++++ src/rules/rulesConverters.ts | 6 ++++-- 3 files changed, 34 insertions(+), 2 deletions(-) create mode 100644 src/rules/converters/codelyzer/no-forward-ref.ts create mode 100644 src/rules/converters/codelyzer/tests/no-forward-ref.test.ts diff --git a/src/rules/converters/codelyzer/no-forward-ref.ts b/src/rules/converters/codelyzer/no-forward-ref.ts new file mode 100644 index 000000000..6ff30598d --- /dev/null +++ b/src/rules/converters/codelyzer/no-forward-ref.ts @@ -0,0 +1,12 @@ +import { RuleConverter } from "../../converter"; + +export const convertNoForwardRef: RuleConverter = () => { + return { + rules: [ + { + ruleName: "@angular-eslint/no-forward-ref", + }, + ], + plugins: ["@angular-eslint/eslint-plugin"], + }; +}; diff --git a/src/rules/converters/codelyzer/tests/no-forward-ref.test.ts b/src/rules/converters/codelyzer/tests/no-forward-ref.test.ts new file mode 100644 index 000000000..e1a664316 --- /dev/null +++ b/src/rules/converters/codelyzer/tests/no-forward-ref.test.ts @@ -0,0 +1,18 @@ +import { convertNoForwardRef } from "../no-forward-ref"; + +describe(convertNoForwardRef, () => { + test("conversion without arguments", () => { + const result = convertNoForwardRef({ + ruleArguments: [], + }); + + expect(result).toEqual({ + rules: [ + { + ruleName: "@angular-eslint/no-forward-ref", + }, + ], + plugins: ["@angular-eslint/eslint-plugin"], + }); + }); +}); diff --git a/src/rules/rulesConverters.ts b/src/rules/rulesConverters.ts index b39115c08..71352bb27 100644 --- a/src/rules/rulesConverters.ts +++ b/src/rules/rulesConverters.ts @@ -146,6 +146,7 @@ import { convertDirectiveClassSuffix } from "./converters/codelyzer/directive-cl import { convertDirectiveSelector } from "./converters/codelyzer/directive-selector"; import { convertNoAttributeDecorator } from "./converters/codelyzer/no-attribute-decorator"; import { convertUsePipeDecorator } from "./converters/codelyzer/use-pipe-decorator"; +import { convertNoForwardRef } from "./converters/codelyzer/no-forward-ref"; /** * Keys TSLint rule names to their ESLint rule converters. @@ -218,8 +219,9 @@ export const rulesConverters = new Map([ ["no-eval", convertNoEval], ["no-floating-promises", convertNoFloatingPromises], ["no-for-in-array", convertNoForInArray], - ["no-implicit-dependencies", convertNoImplicitDependencies], ["no-for-in", convertNoForIn], + ["no-forward-ref", convertNoForwardRef], + ["no-implicit-dependencies", convertNoImplicitDependencies], ["no-import-side-effect", convertNoImportSideEffect], ["no-inferrable-types", convertNoInferrableTypes], ["no-internal-module", convertNoInternalModule], @@ -238,8 +240,8 @@ export const rulesConverters = new Map([ ["no-parameter-properties", convertNoParameterProperties], ["no-parameter-reassignment", convertNoParameterReassignment], ["no-redundant-jsdoc", convertNoRedundantJsdoc], - ["no-reference", convertNoReference], ["no-reference-import", convertNoReferenceImport], + ["no-reference", convertNoReference], ["no-regex-spaces", convertNoRegexSpaces], ["no-require-imports", convertNoRequireImports], ["no-return-await", convertNoReturnAwait],