From 1f6e074a1cdc2e23ee097d92ba7570e36e46d0d7 Mon Sep 17 00:00:00 2001 From: Ryan Waskiewicz Date: Mon, 4 May 2020 21:26:51 -0400 Subject: [PATCH] Prefer @typescript-eslint/no-unused-expression - Update converter for no-unused-expression to use the @typescript-eslint variation --- src/rules/converters/no-unused-expression.ts | 2 +- .../converters/tests/no-unused-expression.test.ts | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/rules/converters/no-unused-expression.ts b/src/rules/converters/no-unused-expression.ts index 7b87f3f35..b78e6f4fc 100644 --- a/src/rules/converters/no-unused-expression.ts +++ b/src/rules/converters/no-unused-expression.ts @@ -4,7 +4,7 @@ export const convertNoUnusedExpression: RuleConverter = (tslintRule) => { return { rules: [ { - ruleName: "no-unused-expressions", + ruleName: "@typescript-eslint/no-unused-expressions", ...collectNoticesAndArguments(tslintRule.ruleArguments), }, ], diff --git a/src/rules/converters/tests/no-unused-expression.test.ts b/src/rules/converters/tests/no-unused-expression.test.ts index bff5eed65..79d357455 100644 --- a/src/rules/converters/tests/no-unused-expression.test.ts +++ b/src/rules/converters/tests/no-unused-expression.test.ts @@ -12,7 +12,7 @@ describe(convertNoUnusedExpression, () => { notices: [ `The TSLint optional config "allow-new" is the default ESLint behavior and will no longer be ignored.`, ], - ruleName: "no-unused-expressions", + ruleName: "@typescript-eslint/no-unused-expressions", }, ], }); @@ -30,7 +30,7 @@ describe(convertNoUnusedExpression, () => { `The TSLint optional config "allow-new" is the default ESLint behavior and will no longer be ignored.`, ], ruleArguments: [{ allowShortCircuit: true }], - ruleName: "no-unused-expressions", + ruleName: "@typescript-eslint/no-unused-expressions", }, ], }); @@ -45,7 +45,7 @@ describe(convertNoUnusedExpression, () => { rules: [ { ruleArguments: [{ allowTaggedTemplates: true }], - ruleName: "no-unused-expressions", + ruleName: "@typescript-eslint/no-unused-expressions", }, ], }); @@ -60,7 +60,7 @@ describe(convertNoUnusedExpression, () => { rules: [ { ruleArguments: [{ allowShortCircuit: true }], - ruleName: "no-unused-expressions", + ruleName: "@typescript-eslint/no-unused-expressions", }, ], }); @@ -75,7 +75,7 @@ describe(convertNoUnusedExpression, () => { rules: [ { ruleArguments: [{ allowTaggedTemplates: true, allowShortCircuit: true }], - ruleName: "no-unused-expressions", + ruleName: "@typescript-eslint/no-unused-expressions", }, ], });