From b4aca8d9f7d70eaf38def2f25ad46e65fcf506ab Mon Sep 17 00:00:00 2001 From: moznion Date: Wed, 1 Apr 2020 00:43:51 +0900 Subject: [PATCH 1/2] Support a converter for `no-reference-import` rule ref: https://github.com/typescript-eslint/tslint-to-eslint-config/issues/367 --- src/rules/converters/no-reference-import.ts | 18 ++++++++++++++ .../tests/no-reference-import.test.ts | 24 +++++++++++++++++++ src/rules/rulesConverters.ts | 2 ++ 3 files changed, 44 insertions(+) create mode 100644 src/rules/converters/no-reference-import.ts create mode 100644 src/rules/converters/tests/no-reference-import.test.ts diff --git a/src/rules/converters/no-reference-import.ts b/src/rules/converters/no-reference-import.ts new file mode 100644 index 000000000..38f903b01 --- /dev/null +++ b/src/rules/converters/no-reference-import.ts @@ -0,0 +1,18 @@ +import { RuleConverter } from "../converter"; + +export const convertNoReferenceImport: RuleConverter = () => { + return { + rules: [ + { + ruleName: "@typescript-eslint/triple-slash-reference", + ruleArguments: [ + { + path: "always", + types: "prefer-import", + lib: "always", + }, + ], + }, + ], + }; +}; diff --git a/src/rules/converters/tests/no-reference-import.test.ts b/src/rules/converters/tests/no-reference-import.test.ts new file mode 100644 index 000000000..157b06652 --- /dev/null +++ b/src/rules/converters/tests/no-reference-import.test.ts @@ -0,0 +1,24 @@ +import { convertNoReferenceImport } from "../no-reference-import"; + +describe(convertNoReferenceImport, () => { + test("conversion without arguments", () => { + const result = convertNoReferenceImport({ + ruleArguments: [], + }); + + expect(result).toEqual({ + rules: [ + { + ruleName: "@typescript-eslint/triple-slash-reference", + ruleArguments: [ + { + path: "always", + types: "prefer-import", + lib: "always", + }, + ], + }, + ], + }); + }); +}); diff --git a/src/rules/rulesConverters.ts b/src/rules/rulesConverters.ts index 78a36d1cc..ee97da459 100644 --- a/src/rules/rulesConverters.ts +++ b/src/rules/rulesConverters.ts @@ -133,6 +133,7 @@ import { convertUnnecessaryConstructor } from "./converters/unnecessary-construc import { convertUseDefaultTypeParameter } from "./converters/use-default-type-parameter"; import { convertUseIsnan } from "./converters/use-isnan"; import { convertVariableName } from "./converters/variable-name"; +import { convertNoReferenceImport } from "./converters/no-reference-import"; /** * Keys TSLint rule names to their ESLint rule converters. @@ -219,6 +220,7 @@ export const rulesConverters = new Map([ ["no-parameter-reassignment", convertNoParameterReassignment], ["no-redundant-jsdoc", convertNoRedundantJsdoc], ["no-reference", convertNoReference], + ["no-reference-import", convertNoReferenceImport], ["no-regex-spaces", convertNoRegexSpaces], ["no-require-imports", convertNoRequireImports], ["no-return-await", convertNoReturnAwait], From 565c583694612fbaefc2c67674749dece30ab288 Mon Sep 17 00:00:00 2001 From: Josh Goldberg Date: Tue, 31 Mar 2020 22:47:13 -0400 Subject: [PATCH 2/2] Quick alphabetization ;) --- src/rules/rulesConverters.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/rules/rulesConverters.ts b/src/rules/rulesConverters.ts index ee97da459..95671e19e 100644 --- a/src/rules/rulesConverters.ts +++ b/src/rules/rulesConverters.ts @@ -79,6 +79,7 @@ import { convertNoParameterProperties } from "./converters/no-parameter-properti import { convertNoParameterReassignment } from "./converters/no-parameter-reassignment"; import { convertNoRedundantJsdoc } from "./converters/no-redundant-jsdoc"; import { convertNoReference } from "./converters/no-reference"; +import { convertNoReferenceImport } from "./converters/no-reference-import"; import { convertNoRegexSpaces } from "./converters/no-regex-spaces"; import { convertNoRequireImports } from "./converters/no-require-imports"; import { convertNoReturnAwait } from "./converters/no-return-await"; @@ -133,7 +134,6 @@ import { convertUnnecessaryConstructor } from "./converters/unnecessary-construc import { convertUseDefaultTypeParameter } from "./converters/use-default-type-parameter"; import { convertUseIsnan } from "./converters/use-isnan"; import { convertVariableName } from "./converters/variable-name"; -import { convertNoReferenceImport } from "./converters/no-reference-import"; /** * Keys TSLint rule names to their ESLint rule converters.