From 26f15086ff41f7814b5d45ab12d1c40e41086293 Mon Sep 17 00:00:00 2001 From: Ivan Nikulin Date: Mon, 16 Mar 2020 22:14:04 +0200 Subject: [PATCH] Fix arrow-parens converter --- src/rules/converters/arrow-parens.ts | 7 ++++--- .../converters/tests/arrow-parens.test.ts | 19 ++----------------- 2 files changed, 6 insertions(+), 20 deletions(-) diff --git a/src/rules/converters/arrow-parens.ts b/src/rules/converters/arrow-parens.ts index d86758d07..188754736 100644 --- a/src/rules/converters/arrow-parens.ts +++ b/src/rules/converters/arrow-parens.ts @@ -2,9 +2,10 @@ import { RuleConverter } from "../converter"; export const convertArrowParens: RuleConverter = tslintRule => { const ruleArguments = [ - tslintRule.ruleArguments.length !== 0 && tslintRule.ruleArguments[0] === "always" - ? "always" - : "as-needed", + tslintRule.ruleArguments.length !== 0 && + tslintRule.ruleArguments[0] === "ban-single-arg-parens" + ? "as-needed" + : "always", ]; return { diff --git a/src/rules/converters/tests/arrow-parens.test.ts b/src/rules/converters/tests/arrow-parens.test.ts index 9562c4ef0..c6a3d3326 100644 --- a/src/rules/converters/tests/arrow-parens.test.ts +++ b/src/rules/converters/tests/arrow-parens.test.ts @@ -6,21 +6,6 @@ describe(convertArrowParens, () => { ruleArguments: [], }); - expect(result).toEqual({ - rules: [ - { - ruleArguments: ["as-needed"], - ruleName: "arrow-parens", - }, - ], - }); - }); - - test("conversion with an always argument", () => { - const result = convertArrowParens({ - ruleArguments: ["always"], - }); - expect(result).toEqual({ rules: [ { @@ -31,9 +16,9 @@ describe(convertArrowParens, () => { }); }); - test("conversion with an as-needed argument", () => { + test("conversion with a ban-single-arg-parens argument", () => { const result = convertArrowParens({ - ruleArguments: ["as-needed"], + ruleArguments: ["ban-single-arg-parens"], }); expect(result).toEqual({