From 59f05f4afd89e005a094138068a708516c68864b Mon Sep 17 00:00:00 2001
From: Dmytro Borysovskyi <bbbara10@gmail.com>
Date: Mon, 30 Dec 2019 13:18:53 +0200
Subject: [PATCH] fix(reporting): "do not have an ESLint equivalent" is
 misleading #299

---
 src/reporting/reportConversionResults.test.ts              | 6 +++---
 src/reporting/reportConversionResults.ts                   | 2 +-
 src/reporting/reportEditorSettingConversionResults.test.ts | 6 +++---
 src/reporting/reportEditorSettingConversionResults.ts      | 3 ++-
 4 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/src/reporting/reportConversionResults.test.ts b/src/reporting/reportConversionResults.test.ts
index 1ef8a27ad..0cbdb4ccc 100644
--- a/src/reporting/reportConversionResults.test.ts
+++ b/src/reporting/reportConversionResults.test.ts
@@ -172,7 +172,7 @@ describe("reportConversionResults", () => {
         );
         expectEqualWrites(
             logger.info.write,
-            "tslint-rule-one does not yet have an ESLint equivalent.",
+            'tslint-to-eslint-config does not know the ESLint equivalent for TSLint\'s "tslint-rule-one"',
         );
     });
 
@@ -206,8 +206,8 @@ describe("reportConversionResults", () => {
         );
         expectEqualWrites(
             logger.info.write,
-            "tslint-rule-one does not yet have an ESLint equivalent.",
-            "tslint-rule-two does not yet have an ESLint equivalent.",
+            'tslint-to-eslint-config does not know the ESLint equivalent for TSLint\'s "tslint-rule-one"',
+            'tslint-to-eslint-config does not know the ESLint equivalent for TSLint\'s "tslint-rule-two"',
         );
     });
 
diff --git a/src/reporting/reportConversionResults.ts b/src/reporting/reportConversionResults.ts
index af5e167bb..648891175 100644
--- a/src/reporting/reportConversionResults.ts
+++ b/src/reporting/reportConversionResults.ts
@@ -29,7 +29,7 @@ export const reportConversionResults = (
         logMissingConversionTarget(
             "rule",
             (setting: TSLintRuleOptions) =>
-                `${setting.ruleName} does not yet have an ESLint equivalent.${EOL}`,
+                `tslint-to-eslint-config does not know the ESLint equivalent for TSLint's "${setting.ruleName}"${EOL}`,
             ruleConversionResults.missing,
             dependencies.logger,
             [
diff --git a/src/reporting/reportEditorSettingConversionResults.test.ts b/src/reporting/reportEditorSettingConversionResults.test.ts
index c7df31922..9bbff1386 100644
--- a/src/reporting/reportEditorSettingConversionResults.test.ts
+++ b/src/reporting/reportEditorSettingConversionResults.test.ts
@@ -126,7 +126,7 @@ describe("reportEditorSettingConversionResults", () => {
         );
         expectEqualWrites(
             logger.info.write,
-            "tslint-editor-setting-one does not yet have an ESLint equivalent.",
+            'tslint-to-eslint-config does not know the ESLint equivalent for TSLint\'s "tslint-editor-setting-one"',
         );
     });
 
@@ -156,8 +156,8 @@ describe("reportEditorSettingConversionResults", () => {
         );
         expectEqualWrites(
             logger.info.write,
-            "tslint-editor-setting-one does not yet have an ESLint equivalent.",
-            "tslint-editor-setting-two does not yet have an ESLint equivalent.",
+            'tslint-to-eslint-config does not know the ESLint equivalent for TSLint\'s "tslint-editor-setting-one"',
+            'tslint-to-eslint-config does not know the ESLint equivalent for TSLint\'s "tslint-editor-setting-two"',
         );
     });
 });
diff --git a/src/reporting/reportEditorSettingConversionResults.ts b/src/reporting/reportEditorSettingConversionResults.ts
index 12ebf1a29..938988abd 100644
--- a/src/reporting/reportEditorSettingConversionResults.ts
+++ b/src/reporting/reportEditorSettingConversionResults.ts
@@ -28,7 +28,8 @@ export const reportEditorSettingConversionResults = (
     if (editorSettingConversionResults.missing.length !== 0) {
         const missingEditorSettingOutputMapping = (
             editorSetting: Pick<EditorSetting, "editorSettingName">,
-        ) => `${editorSetting.editorSettingName} does not yet have an ESLint equivalent.${EOL}`;
+        ) =>
+            `tslint-to-eslint-config does not know the ESLint equivalent for TSLint's "${editorSetting.editorSettingName}"${EOL}`;
         logMissingConversionTarget(
             "editor setting",
             missingEditorSettingOutputMapping,