From a63f64e0307fb0fa4054deff1f0adf5eb2896e6e Mon Sep 17 00:00:00 2001 From: bouzuya Date: Thu, 12 Dec 2019 23:35:50 +0900 Subject: [PATCH 1/2] fix convertSemicolon ruleArguments --- src/rules/converters/semicolon.ts | 1 - src/rules/converters/tests/semicolon.test.ts | 4 ---- 2 files changed, 5 deletions(-) diff --git a/src/rules/converters/semicolon.ts b/src/rules/converters/semicolon.ts index ec75e7db8..51d1ea55a 100644 --- a/src/rules/converters/semicolon.ts +++ b/src/rules/converters/semicolon.ts @@ -24,7 +24,6 @@ export const convertSemicolon: RuleConverter = tslintRule => { : [ { ruleArguments: [ - "error", { multiline: { delimiter: getMultilineDelimiter(tslintRule.ruleArguments[0]), diff --git a/src/rules/converters/tests/semicolon.test.ts b/src/rules/converters/tests/semicolon.test.ts index 55c96ffdf..f7cb30a49 100644 --- a/src/rules/converters/tests/semicolon.test.ts +++ b/src/rules/converters/tests/semicolon.test.ts @@ -14,7 +14,6 @@ describe(convertSemicolon, () => { }, { ruleArguments: [ - "error", { multiline: { delimiter: "semi", @@ -45,7 +44,6 @@ describe(convertSemicolon, () => { }, { ruleArguments: [ - "error", { multiline: { delimiter: "none", @@ -77,7 +75,6 @@ describe(convertSemicolon, () => { { ruleName: "@typescript-eslint/member-delimiter-style", ruleArguments: [ - "error", { multiline: { delimiter: "semi", @@ -111,7 +108,6 @@ describe(convertSemicolon, () => { { ruleName: "@typescript-eslint/member-delimiter-style", ruleArguments: [ - "error", { multiline: { delimiter: "none", From 69e8e47c9a2bf31529ad1c9676bcac47bbb83e71 Mon Sep 17 00:00:00 2001 From: bouzuya Date: Thu, 12 Dec 2019 23:48:56 +0900 Subject: [PATCH 2/2] fix convertNewlineBeforeReturn ruleArguments --- src/rules/converters/newline-before-return.ts | 1 - src/rules/converters/tests/newline-before-return.test.ts | 1 - 2 files changed, 2 deletions(-) diff --git a/src/rules/converters/newline-before-return.ts b/src/rules/converters/newline-before-return.ts index 3e6916a2f..102362ec0 100644 --- a/src/rules/converters/newline-before-return.ts +++ b/src/rules/converters/newline-before-return.ts @@ -6,7 +6,6 @@ export const convertNewlineBeforeReturn: RuleConverter = () => { { ruleName: "padding-line-between-statements", ruleArguments: [ - "error", { blankLine: "always", prev: "*", diff --git a/src/rules/converters/tests/newline-before-return.test.ts b/src/rules/converters/tests/newline-before-return.test.ts index 97f8dc75a..d216ce63c 100644 --- a/src/rules/converters/tests/newline-before-return.test.ts +++ b/src/rules/converters/tests/newline-before-return.test.ts @@ -11,7 +11,6 @@ describe(convertNewlineBeforeReturn, () => { { ruleName: "padding-line-between-statements", ruleArguments: [ - "error", { blankLine: "always", next: "return",