From 272d3e9bf80207d8f7eb97e78fd9f6d166f37f7e Mon Sep 17 00:00:00 2001 From: Holger Jeromin Date: Fri, 11 Oct 2019 10:25:15 +0200 Subject: [PATCH 1/3] Update reportConversionResults.test.ts --- src/reporting/reportConversionResults.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/reporting/reportConversionResults.test.ts b/src/reporting/reportConversionResults.test.ts index a536d20ce..80c629e77 100644 --- a/src/reporting/reportConversionResults.test.ts +++ b/src/reporting/reportConversionResults.test.ts @@ -200,7 +200,7 @@ describe("reportConversionResults", () => { // Assert expectEqualWrites( logger.stdout.write, - "👀 2 rules do not yet have ESLint equivalents; defaulting to eslint-plugin-tslint. 👀", + "👀 2 rules do not yet have ESLint equivalents (see generated log file); defaulting to eslint-plugin-tslint for these rules. 👀", ); expectEqualWrites( logger.info.write, From 5a77ccfbe9c051cac8b9cf7a4c7aaee863cc3e80 Mon Sep 17 00:00:00 2001 From: Holger Jeromin Date: Fri, 11 Oct 2019 10:30:40 +0200 Subject: [PATCH 2/3] Update reportConversionResults.ts --- src/reporting/reportConversionResults.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/reporting/reportConversionResults.ts b/src/reporting/reportConversionResults.ts index 9aceae1b9..2eb2a1a15 100644 --- a/src/reporting/reportConversionResults.ts +++ b/src/reporting/reportConversionResults.ts @@ -62,7 +62,7 @@ const logMissingRules = (missing: TSLintRuleOptions[], logger: Logger) => { : " rules do not yet have ESLint equivalents", ), ); - logger.stdout.write(chalk.yellow("; defaulting to eslint-plugin-tslint.")); + logger.stdout.write(chalk.yellow(" (see generated log file); defaulting to eslint-plugin-tslint for these rules.")); logger.stdout.write(chalk.yellowBright(` 👀${EOL}`)); logger.info.write( From dc03a2c4dc9f2b52af4f2c6e4ca328bbde8e542e Mon Sep 17 00:00:00 2001 From: Holger Jeromin Date: Fri, 11 Oct 2019 10:38:12 +0200 Subject: [PATCH 3/3] updated test for single rule output --- src/reporting/reportConversionResults.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/reporting/reportConversionResults.test.ts b/src/reporting/reportConversionResults.test.ts index 80c629e77..9a239b597 100644 --- a/src/reporting/reportConversionResults.test.ts +++ b/src/reporting/reportConversionResults.test.ts @@ -167,7 +167,7 @@ describe("reportConversionResults", () => { // Assert expectEqualWrites( logger.stdout.write, - "👀 1 rule does not yet have an ESLint equivalent; defaulting to eslint-plugin-tslint. 👀", + "👀 1 rule does not yet have an ESLint equivalent (see generated log file); defaulting to eslint-plugin-tslint for these rules. 👀", ); expectEqualWrites( logger.info.write,