From 3ec4228417b4fe29a53851116d52fd2a86374fff Mon Sep 17 00:00:00 2001 From: Tony Greeley Date: Sat, 5 Oct 2019 19:39:03 -0500 Subject: [PATCH] Added the file extension for a VS Code workspace file to .gitignore. Created a test for use-default-type-parameter, add the rule to rules/converters.ts, and created it it's own converter file. --- .gitignore | 2 ++ src/rules/converters.ts | 2 ++ .../tests/use-default-type-parameter.test.ts | 17 +++++++++++++++++ .../converters/use-default-type-parameter.ts | 11 +++++++++++ 4 files changed, 32 insertions(+) create mode 100644 src/rules/converters/tests/use-default-type-parameter.test.ts create mode 100644 src/rules/converters/use-default-type-parameter.ts diff --git a/.gitignore b/.gitignore index 54654c847..34ee8dfa2 100644 --- a/.gitignore +++ b/.gitignore @@ -9,3 +9,5 @@ test/*.js ~test/jest.config.js !test/tests/**/.eslintrc* !test/tests/**/*.log +#VS Code workspace file +*.code-workspace \ No newline at end of file diff --git a/src/rules/converters.ts b/src/rules/converters.ts index 78b2b9e94..801dbe962 100644 --- a/src/rules/converters.ts +++ b/src/rules/converters.ts @@ -108,6 +108,7 @@ import { convertUnifiedSignatures } from "./converters/unified-signatures"; import { convertUnnecessaryBind } from "./converters/unnecessary-bind"; import { convertUnnecessaryConstructor } from "./converters/unnecessary-constructor"; import { convertUseIsnan } from "./converters/use-isnan"; +import { convertUseDefaultTypeParameter } from "./converters/use-default-type-parameter"; import { convertQuotemark } from "./converters/quotemark"; import { convertTripleEquals } from "./converters/triple-equals"; @@ -227,6 +228,7 @@ export const converters = new Map([ ["unnecessary-bind", convertUnnecessaryBind], ["unnecessary-constructor", convertUnnecessaryConstructor], ["use-isnan", convertUseIsnan], + ["use-default-type-parameter", convertUseDefaultTypeParameter], // These converters are all for rules that need more complex option conversions. // Some of them will likely need to have notices about changed lint behaviors... diff --git a/src/rules/converters/tests/use-default-type-parameter.test.ts b/src/rules/converters/tests/use-default-type-parameter.test.ts new file mode 100644 index 000000000..ab9cd8cd5 --- /dev/null +++ b/src/rules/converters/tests/use-default-type-parameter.test.ts @@ -0,0 +1,17 @@ +import { convertUseDefaultTypeParameter } from "../use-default-type-parameter"; + +describe(convertUseDefaultTypeParameter, () => { + test("conversion without arguments", () => { + const result = convertUseDefaultTypeParameter({ + ruleArguments: [], + }); + + expect(result).toEqual({ + rules: [ + { + ruleName: "@typescript-eslint/use-default-type-parameter", + }, + ], + }); + }); +}); diff --git a/src/rules/converters/use-default-type-parameter.ts b/src/rules/converters/use-default-type-parameter.ts new file mode 100644 index 000000000..3b16faa2c --- /dev/null +++ b/src/rules/converters/use-default-type-parameter.ts @@ -0,0 +1,11 @@ +import { RuleConverter } from "../converter"; + +export const convertUseDefaultTypeParameter: RuleConverter = () => { + return { + rules: [ + { + ruleName: "@typescript-eslint/use-default-type-parameter", + }, + ], + }; +};