From cca61978c8942c012ce51bdf3de1d70a2f243428 Mon Sep 17 00:00:00 2001 From: KingDarBoja Date: Sun, 16 May 2021 13:07:39 -0500 Subject: [PATCH 1/2] Add no-dynamic-delete converter --- .../lintConfigs/rules/ruleConverters.ts | 3 +++ .../rules/ruleConverters/no-dynamic-delete.ts | 11 +++++++++++ .../tests/no-dynamic-delete.test.ts | 17 +++++++++++++++++ 3 files changed, 31 insertions(+) create mode 100644 src/converters/lintConfigs/rules/ruleConverters/no-dynamic-delete.ts create mode 100644 src/converters/lintConfigs/rules/ruleConverters/tests/no-dynamic-delete.test.ts diff --git a/src/converters/lintConfigs/rules/ruleConverters.ts b/src/converters/lintConfigs/rules/ruleConverters.ts index ccdb8339e..ddada80bf 100644 --- a/src/converters/lintConfigs/rules/ruleConverters.ts +++ b/src/converters/lintConfigs/rules/ruleConverters.ts @@ -53,6 +53,7 @@ import { convertNoDuplicateImports } from "./ruleConverters/no-duplicate-imports import { convertNoDuplicateSuper } from "./ruleConverters/no-duplicate-super"; import { convertNoDuplicateSwitchCase } from "./ruleConverters/no-duplicate-switch-case"; import { convertNoDuplicateVariable } from "./ruleConverters/no-duplicate-variable"; +import { convertNoDynamicDelete } from './ruleConverters/no-dynamic-delete'; import { convertNoEmpty } from "./ruleConverters/no-empty"; import { convertNoEmptyInterface } from "./ruleConverters/no-empty-interface"; import { convertNoEval } from "./ruleConverters/no-eval"; @@ -218,6 +219,7 @@ import { convertNoSubjectValue } from "./ruleConverters/eslint-plugin-rxjs/no-su import { convertNoUnboundMethods } from "./ruleConverters/eslint-plugin-rxjs/no-unbound-methods"; import { convertNoUnsafeSubjectNext } from "./ruleConverters/eslint-plugin-rxjs/no-unsafe-subject-next"; import { convertNoUnsafeTakeUntil } from "./ruleConverters/eslint-plugin-rxjs/no-unsafe-takeuntil"; +import _ from "lodash"; /** * Keys TSLint rule names to their ESLint rule converters. @@ -298,6 +300,7 @@ export const ruleConverters = new Map([ ["no-duplicate-super", convertNoDuplicateSuper], ["no-duplicate-switch-case", convertNoDuplicateSwitchCase], ["no-duplicate-variable", convertNoDuplicateVariable], + ["no-dynamic-delete", convertNoDynamicDelete], ["no-empty-interface", convertNoEmptyInterface], ["no-empty", convertNoEmpty], ["no-eval", convertNoEval], diff --git a/src/converters/lintConfigs/rules/ruleConverters/no-dynamic-delete.ts b/src/converters/lintConfigs/rules/ruleConverters/no-dynamic-delete.ts new file mode 100644 index 000000000..6cf175987 --- /dev/null +++ b/src/converters/lintConfigs/rules/ruleConverters/no-dynamic-delete.ts @@ -0,0 +1,11 @@ +import { RuleConverter } from "../ruleConverter"; + +export const convertNoDynamicDelete: RuleConverter = () => { + return { + rules: [ + { + ruleName: "@typescript-eslint/no-dynamic-delete", + }, + ], + }; +}; diff --git a/src/converters/lintConfigs/rules/ruleConverters/tests/no-dynamic-delete.test.ts b/src/converters/lintConfigs/rules/ruleConverters/tests/no-dynamic-delete.test.ts new file mode 100644 index 000000000..f5f6f6d7a --- /dev/null +++ b/src/converters/lintConfigs/rules/ruleConverters/tests/no-dynamic-delete.test.ts @@ -0,0 +1,17 @@ +import { convertNoDynamicDelete } from "../no-dynamic-delete"; + +describe(convertNoDynamicDelete, () => { + test("conversion without arguments", () => { + const result = convertNoDynamicDelete({ + ruleArguments: [], + }); + + expect(result).toEqual({ + rules: [ + { + ruleName: "@typescript-eslint/no-dynamic-delete", + }, + ], + }); + }); +}); From 1d85d307307e811e3e83e1d483669f1a8cff424e Mon Sep 17 00:00:00 2001 From: Josh Goldberg Date: Sun, 16 May 2021 14:29:51 -0400 Subject: [PATCH 2/2] Update src/converters/lintConfigs/rules/ruleConverters.ts --- src/converters/lintConfigs/rules/ruleConverters.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/src/converters/lintConfigs/rules/ruleConverters.ts b/src/converters/lintConfigs/rules/ruleConverters.ts index ddada80bf..0458cb302 100644 --- a/src/converters/lintConfigs/rules/ruleConverters.ts +++ b/src/converters/lintConfigs/rules/ruleConverters.ts @@ -219,7 +219,6 @@ import { convertNoSubjectValue } from "./ruleConverters/eslint-plugin-rxjs/no-su import { convertNoUnboundMethods } from "./ruleConverters/eslint-plugin-rxjs/no-unbound-methods"; import { convertNoUnsafeSubjectNext } from "./ruleConverters/eslint-plugin-rxjs/no-unsafe-subject-next"; import { convertNoUnsafeTakeUntil } from "./ruleConverters/eslint-plugin-rxjs/no-unsafe-takeuntil"; -import _ from "lodash"; /** * Keys TSLint rule names to their ESLint rule converters.