From 7bf180d93a7f34d96e47e14e781dcbbd4762c748 Mon Sep 17 00:00:00 2001 From: KingDarBoja Date: Sun, 16 May 2021 12:46:26 -0500 Subject: [PATCH] Add rxjs no-finnish converter --- .../lintConfigs/rules/ruleConverters.ts | 2 ++ .../eslint-plugin-rxjs/no-finnish.ts | 12 ++++++++++++ .../tests/no-finnish.test.ts | 18 ++++++++++++++++++ 3 files changed, 32 insertions(+) create mode 100644 src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-rxjs/no-finnish.ts create mode 100644 src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-rxjs/tests/no-finnish.test.ts diff --git a/src/converters/lintConfigs/rules/ruleConverters.ts b/src/converters/lintConfigs/rules/ruleConverters.ts index ccdb8339e..911835112 100644 --- a/src/converters/lintConfigs/rules/ruleConverters.ts +++ b/src/converters/lintConfigs/rules/ruleConverters.ts @@ -205,6 +205,7 @@ import { convertJsxWrapMultiline } from "./ruleConverters/eslint-plugin-react/js import { convertNoAsyncSubscribe } from "./ruleConverters/eslint-plugin-rxjs/no-async-subscribe"; import { convertNoImplicitAnyCatch } from "./ruleConverters/eslint-plugin-rxjs/no-implicit-any-catch"; import { convertNoCreate } from "./ruleConverters/eslint-plugin-rxjs/no-create"; +import { convertNoFinnish } from "./ruleConverters/eslint-plugin-rxjs/no-finnish"; import { convertNoIgnoredNotifier } from "./ruleConverters/eslint-plugin-rxjs/no-ignored-notifier"; import { convertNoIgnoredReplayBuffer } from "./ruleConverters/eslint-plugin-rxjs/no-ignored-replay-buffer"; import { convertNoIgnoredTakeWhileValue } from "./ruleConverters/eslint-plugin-rxjs/no-ignored-takewhile-value"; @@ -425,6 +426,7 @@ export const ruleConverters = new Map([ ["rxjs-no-async-subscribe", convertNoAsyncSubscribe], ["rxjs-no-implicit-any-catch", convertNoImplicitAnyCatch], ["rxjs-no-create", convertNoCreate], + ["rxjs-no-finnish", convertNoFinnish], ["rxjs-no-ignored-notifier", convertNoIgnoredNotifier], ["rxjs-no-ignored-replay-buffer", convertNoIgnoredReplayBuffer], ["rxjs-no-ignored-takewhile-value", convertNoIgnoredTakeWhileValue], diff --git a/src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-rxjs/no-finnish.ts b/src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-rxjs/no-finnish.ts new file mode 100644 index 000000000..cd15c12ee --- /dev/null +++ b/src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-rxjs/no-finnish.ts @@ -0,0 +1,12 @@ +import { RuleConverter } from "../../ruleConverter"; + +export const convertNoFinnish: RuleConverter = () => { + return { + rules: [ + { + ruleName: "rxjs/no-finnish", + }, + ], + plugins: ["eslint-plugin-rxjs"], + }; +}; diff --git a/src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-rxjs/tests/no-finnish.test.ts b/src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-rxjs/tests/no-finnish.test.ts new file mode 100644 index 000000000..62a2ce084 --- /dev/null +++ b/src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-rxjs/tests/no-finnish.test.ts @@ -0,0 +1,18 @@ +import { convertNoFinnish } from "../no-finnish"; + +describe(convertNoFinnish, () => { + test("conversion without arguments", () => { + const result = convertNoFinnish({ + ruleArguments: [], + }); + + expect(result).toEqual({ + rules: [ + { + ruleName: "rxjs/no-finnish", + }, + ], + plugins: ["eslint-plugin-rxjs"], + }); + }); +});