add converter for space-within-parens rule

Author: bmeverett

src/rules/converters.ts

@@ -97,6 +97,7 @@ import { convertPromiseFunctionAsync } from "./converters/promise-function-async
 import { convertRadix } from "./converters/radix";
 import { convertRestrictPlusOperands } from "./converters/restrict-plus-operands";
 import { convertSpaceBeforeFunctionParen } from "./converters/space-before-function-paren";
+import { convertSpaceWithinParens } from "./converters/space-within-parens";
 import { convertSwitchDefault } from "./converters/switch-default";
 import { convertTypedefWhitespace } from "./converters/typedef-whitespace";
 import { convertTypeLiteralDelimiter } from "./converters/type-literal-delimiter";
@@ -210,6 +211,7 @@ export const converters = new Map([
     ["prefer-readonly", convertPreferReadonly],
     ["prefer-template", convertPreferTemplate],
     ["space-before-function-paren", convertSpaceBeforeFunctionParen],
+    ["space-within-parens", convertSpaceWithinParens],
     ["switch-default", convertSwitchDefault],
     ["no-banned-terms", convertNoBannedTerms],
     ["no-constant-condition", convertNoConstantCondition],
@@ -222,12 +224,12 @@ export const converters = new Map([
     ["quotemark", convertQuotemark],
     ["triple-equals", convertTripleEquals],
 
-    // These converters are all for rules that need more complex option conversions.
-    // Some of them will likely need to have notices about changed lint behaviors...
-    // If you're willing to take on that work, that'd be great! Please send PRs! 💖
-    // As these are enabled, they should be added in sorted order to the list above.
+    // these converters are all for rules that need more complex option conversions.
+    // some of them will likely need to have notices about changed lint behaviors...
+    // if you're willing to take on that work, that'd be great! Please send PRs! 💖
+    // as these are enabled, they should be added in sorted order to the list above.
 
-    // TSLint core rules:
+    // tSLint core rules:
     // ["ban", convertBan], // no-restricted-properties
     // ["import-blacklist", convertImportBlacklist], // no-restricted-imports
     // ["newline-before-return", convertNewlineBeforeReturn],
@@ -236,7 +238,8 @@ export const converters = new Map([
     // ["no-trailing-whitespace", convertNoTrailingWhitespace], //  no-trailing-spaces
     // ["no-unused-expression", convertNoUnusedExpression], // no-unused-expressions
     // ["no-void-expression", convertNoVoidExpression], // (no exact equivalent)
-    // ["space-within-parens", convertSpaceWithinParens], // space-in-parens
+    // ["quotemark", convertQuotemark], // quotes
+    // ["triple-equals", convertTripleEquals], // eqeqeq
     // ["variable-name", convertVariableName], // a bunch of rules...
 
     // tslint-microsoft-contrib rules:

src/rules/converters/space-within-parens.ts

@@ -0,0 +1,14 @@
+import { RuleConverter } from "../converter";
+
+export const convertSpaceWithinParens: RuleConverter = tslintRule => {
+    return {
+        rules: [
+            {
+                ...(tslintRule.ruleArguments.length !== 0 && {
+                    ruleArguments: tslintRule.ruleArguments,
+                }),
+                ruleName: "@typescript-eslint/space-within-parens",
+            },
+        ],
+    };
+};

src/rules/converters/tests/space-within-parens.test.ts

@@ -0,0 +1,32 @@
+import { convertSpaceWithinParens } from "../space-within-parens";
+
+describe(convertSpaceWithinParens, () => {
+    test("conversion without arguments", () => {
+        const result = convertSpaceWithinParens({
+            ruleArguments: [],
+        });
+
+        expect(result).toEqual({
+            rules: [
+                {
+                    ruleName: "@typescript-eslint/space-within-parens",
+                },
+            ],
+        });
+    });
+
+    test("conversion with min spaces arguement", () => {
+        const result = convertSpaceWithinParens({
+            ruleArguments: [5],
+        });
+
+        expect(result).toEqual({
+            rules: [
+                {
+                    ruleArguments: [5],
+                    ruleName: "@typescript-eslint/space-within-parens",
+                },
+            ],
+        });
+    });
+});