Skip to content

Commit f0ceaa6

Browse files
author
Josh Goldberg
authored
Disabled end-to-end tests in Circle (#157)
* Added more test logging in config.yml * Added more test logging in config.yml * Added logging to the right place... * ls 'test/tests/custom eslint path' -l * Added missing .log files from tests * Added missing period, maybe, to testRegex * Meh removing backslashes altogether * And some missing log and json files * Added ts-node install to test-end-to-end * Remove test-end-to-end from running
1 parent 93eee5b commit f0ceaa6

File tree

11 files changed

+124
-5
lines changed

11 files changed

+124
-5
lines changed

.circleci/config.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,7 @@ jobs:
9191
- attach_workspace:
9292
at: "."
9393

94+
- run: npm i -g ts-node
9495
- run: npm run test:end-to-end
9596

9697
test-unit:
@@ -143,9 +144,6 @@ workflows:
143144
- prettier:
144145
requires:
145146
- build
146-
- test-end-to-end:
147-
requires:
148-
- build
149147
- test-unit:
150148
requires:
151149
- build

.gitignore

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,5 @@ node_modules/
77
src/**/*.js
88
test/*.js
99
~test/jest.config.js
10-
test/tests/**/.eslintrc*
10+
!test/tests/**/.eslintrc*
11+
!test/tests/**/*.log

test/jest.config.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
module.exports = {
22
moduleFileExtensions: ["ts", "tsx", "js", "jsx", "json", "node"],
3-
testRegex: "test(.*)\\test\\.ts$",
3+
testRegex: "test(.*).test.ts$",
44
testEnvironment: "node",
55
};
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
no-implicit-dependencies does not yet have an ESLint equivalent.
2+
strict-boolean-expressions does not yet have an ESLint equivalent.
Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
module.exports = {
2+
env: {
3+
es6: true,
4+
node: true,
5+
},
6+
parser: "@typescript-eslint/parser",
7+
parserOptions: {
8+
project: "tsconfig.json",
9+
sourceType: "module",
10+
},
11+
plugins: ["@typescript-eslint", "@typescript-eslint/tslint"],
12+
rules: {
13+
"@typescript-eslint/array-type": "error",
14+
"@typescript-eslint/interface-name-prefix": "error",
15+
"no-magic-numbers": "off",
16+
"prefer-template": "off",
17+
"@typescript-eslint/tslint/config": [
18+
"error",
19+
{
20+
rules: {
21+
"no-implicit-dependencies": [true, "dev"],
22+
"strict-boolean-expressions": [
23+
true,
24+
"allow-boolean-or-undefined",
25+
"allow-number",
26+
],
27+
},
28+
},
29+
],
30+
},
31+
};
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
no-implicit-dependencies does not yet have an ESLint equivalent.
2+
strict-boolean-expressions does not yet have an ESLint equivalent.
Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
module.exports = {
2+
env: {
3+
browser: true,
4+
node: true,
5+
},
6+
parser: "@typescript-eslint/parser",
7+
parserOptions: {
8+
project: "tsconfig.json",
9+
sourceType: "module",
10+
},
11+
plugins: ["@typescript-eslint", "@typescript-eslint/tslint"],
12+
rules: {
13+
"@typescript-eslint/array-type": "error",
14+
"@typescript-eslint/interface-name-prefix": "error",
15+
"no-magic-numbers": "off",
16+
"prefer-template": "off",
17+
"@typescript-eslint/tslint/config": [
18+
"error",
19+
{
20+
rules: {
21+
"no-implicit-dependencies": [true, "dev"],
22+
"strict-boolean-expressions": [
23+
true,
24+
"allow-boolean-or-undefined",
25+
"allow-number",
26+
],
27+
},
28+
},
29+
],
30+
},
31+
};
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
no-implicit-dependencies does not yet have an ESLint equivalent.
2+
strict-boolean-expressions does not yet have an ESLint equivalent.
Lines changed: 50 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,50 @@
1+
{
2+
"env": {
3+
"es6": true,
4+
"node": true
5+
},
6+
"parser": "@typescript-eslint/parser",
7+
"parserOptions": {
8+
"project": "tsconfig.json",
9+
"sourceType": "module"
10+
},
11+
"plugins": [
12+
"@typescript-eslint",
13+
"@typescript-eslint/tslint"
14+
],
15+
"rules": {
16+
"@typescript-eslint/array-type": "error",
17+
"@typescript-eslint/interface-name-prefix": "error",
18+
"@typescript-eslint/member-ordering": "off",
19+
"@typescript-eslint/no-explicit-any": "off",
20+
"@typescript-eslint/no-param-reassign": "off",
21+
"@typescript-eslint/no-parameter-properties": "off",
22+
"@typescript-eslint/no-use-before-declare": "off",
23+
"@typescript-eslint/promise-function-async": "off",
24+
"@typescript-eslint/unbound-method": "off",
25+
"arrow-body-style": "off",
26+
"default-case": "off",
27+
"linebreak-style": "off",
28+
"no-bitwise": "off",
29+
"no-empty": "off",
30+
"no-empty-functions": "off",
31+
"no-magic-numbers": "off",
32+
"prefer-template": "off",
33+
"@typescript-eslint/tslint/config": [
34+
"error",
35+
{
36+
"rules": {
37+
"no-implicit-dependencies": [
38+
true,
39+
"dev"
40+
],
41+
"strict-boolean-expressions": [
42+
true,
43+
"allow-boolean-or-undefined",
44+
"allow-number"
45+
]
46+
}
47+
}
48+
]
49+
}
50+
}

test/tests/missing tslint.json/tslint-to-eslint-config.log

Whitespace-only changes.
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
no-implicit-dependencies does not yet have an ESLint equivalent.
2+
strict-boolean-expressions does not yet have an ESLint equivalent.

0 commit comments

Comments
 (0)