Skip to content

Commit e82a137

Browse files
kbrillaKrzysztof BrillaKingDarBoja
authored
Added rxjs-no-nested-subscribe converter (#805)
Co-authored-by: Krzysztof Brilla <brilla.krzysztof@gmail.com> Co-authored-by: Manuel Bojato <30560560+KingDarBoja@users.noreply.github.com>
1 parent 23dc93e commit e82a137

File tree

3 files changed

+32
-0
lines changed

3 files changed

+32
-0
lines changed

src/converters/lintConfigs/rules/ruleConverters.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -188,6 +188,7 @@ import { convertNoAsyncSubscribe } from "./ruleConverters/eslint-plugin-rxjs/no-
188188
import { convertNoIgnoredReplayBuffer } from "./ruleConverters/eslint-plugin-rxjs/no-ignored-replay-buffer";
189189
import { convertNoIgnoredTakeWhileValue } from "./ruleConverters/eslint-plugin-rxjs/no-ignored-takewhile-value";
190190
import { convertNoInternal } from "./ruleConverters/eslint-plugin-rxjs/no-internal";
191+
import { convertNoNestedSubscribe } from "./ruleConverters/eslint-plugin-rxjs/no-nested-subscribe";
191192
import { convertNoRedundantNotify } from "./ruleConverters/eslint-plugin-rxjs/no-redundant-notify";
192193
import { convertNoShareReplay } from "./ruleConverters/eslint-plugin-rxjs/no-sharereplay";
193194
import { convertNoUnsafeSubjectNext } from "./ruleConverters/eslint-plugin-rxjs/no-unsafe-subject-next";
@@ -381,6 +382,7 @@ export const ruleConverters = new Map([
381382
["rxjs-no-ignored-replay-buffer", convertNoIgnoredReplayBuffer],
382383
["rxjs-no-ignored-takewhile-value", convertNoIgnoredTakeWhileValue],
383384
["rxjs-no-internal", convertNoInternal],
385+
["rxjs-no-nested-subscribe", convertNoNestedSubscribe],
384386
["rxjs-no-redundant-notify", convertNoRedundantNotify],
385387
["rxjs-no-sharereplay", convertNoShareReplay],
386388
["rxjs-no-unsafe-subject-next", convertNoUnsafeSubjectNext],
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
import { RuleConverter } from "../../ruleConverter";
2+
3+
export const convertNoNestedSubscribe: RuleConverter = () => {
4+
return {
5+
rules: [
6+
{
7+
ruleName: "rxjs/no-nested-subscribe",
8+
},
9+
],
10+
plugins: ["eslint-plugin-rxjs"],
11+
};
12+
};
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
import { convertNoNestedSubscribe } from "../no-nested-subscribe";
2+
3+
describe(convertNoNestedSubscribe, () => {
4+
test("conversion without arguments", () => {
5+
const result = convertNoNestedSubscribe({
6+
ruleArguments: [],
7+
});
8+
9+
expect(result).toEqual({
10+
rules: [
11+
{
12+
ruleName: "rxjs/no-nested-subscribe",
13+
},
14+
],
15+
plugins: ["eslint-plugin-rxjs"],
16+
});
17+
});
18+
});

0 commit comments

Comments
 (0)