Update typescript-eslint monorepo to v4.4.0 (#735)

* Update typescript-eslint monorepo to v4.4.0

* Converted some interfaces to records

Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Josh Goldberg <me@joshuakgoldberg.com>

Author: 3 people

package-lock.json

@@ -30,8 +30,8 @@
         "@types/jest": "26.0.14",
         "@types/minimatch": "3.0.3",
         "@types/node": "12.12.21",
-        "@typescript-eslint/eslint-plugin": "4.3.0",
-        "@typescript-eslint/parser": "4.3.0",
+        "@typescript-eslint/eslint-plugin": "4.4.0",
+        "@typescript-eslint/parser": "4.4.0",
         "babel-jest": "26.5.2",
         "eslint": "7.11.0",
         "husky": "4.3.0",

package.json

@@ -7,7 +7,7 @@ export const formatConvertedRules = (
     conversionResults: RuleConversionResults,
     tslintConfiguration: TSLintConfiguration,
 ) => {
-    const output: { [i: string]: string | any[] } = {};
+    const output: Record<string, string | any[]> = {};
     const sortedRuleEntries = Array.from(
         conversionResults.converted,
     ).sort(([ruleNameA], [ruleNameB]) => ruleNameA.localeCompare(ruleNameB));

src/converters/lintConfigs/formatConvertedRules.ts

@@ -3,7 +3,7 @@ import { RuleConverter } from "../ruleConverter";
 const IGNORE_CASE_NOTICE = "ESLint (Unicorn plugin) does not support the 'ignore' case.";
 const CASING_BY_FILETYPE_CHANGE =
     "ESLint (Unicorn Plugin) does not support file name casing by file type, so all previously configured casings are now allowed.";
-const CASES_MAP: { [s: string]: string } = {
+const CASES_MAP: Record<string, string> = {
     "camel-case": "camelCase",
     "pascal-case": "pascalCase",
     "kebab-case": "kebabCase",

src/converters/lintConfigs/rules/ruleConverters/file-name-casing.ts

@@ -69,7 +69,7 @@ function collectKeys(
     key: TSLintObjectKey,
     singleline: TSLintObject | undefined,
     multiline: TSLintObject | undefined,
-): { [key: string]: ESLintStringValue } {
+): Record<string, ESLintStringValue> {
     const hasSingleline = Boolean(singleline);
     const hasSinglelineAndFieldExist = Boolean(singleline?.[key]);
     const hasSinglelineAlways = Boolean(singleline && singleline[key] === "always");

src/converters/lintConfigs/rules/ruleConverters/trailing-comma.ts

@@ -23,7 +23,7 @@ export const writeEditorConfigConversionResults = async (
 };
 
 export const formatConvertedSettings = (conversionResults: EditorSettingConversionResults) => {
-    const output: { [i: string]: string | any[] } = {};
+    const output: Record<string, string | any> = {};
     const sortedEntries = Array.from(conversionResults.converted).sort(([nameA], [nameB]) =>
         nameA.localeCompare(nameB),
     );

src/converters/lintConfigs/writeEditorConfigConversionResults.ts

@@ -1 +1 @@
-export type EditorConfiguration = { [key: string]: any };
+export type EditorConfiguration = Record<string, any>;

src/input/editorConfiguration.ts

@@ -15,9 +15,7 @@ export type ESLintConfiguration = {
     rules?: ESLintConfigurationRules;
 };
 
-export type ESLintConfigurationRules = {
-    [i: string]: ESLintConfigurationRuleValue;
-};
+export type ESLintConfigurationRules = Record<string, ESLintConfigurationRuleValue>;
 
 export type ESLintConfigurationRuleValue =
     | RawESLintRuleSeverity