Skip to content

Commit d46d719

Browse files
author
Josh Goldberg
authored
Added converter for no-cookies (#1078)
1 parent 7a4f2b5 commit d46d719

File tree

3 files changed

+42
-0
lines changed

3 files changed

+42
-0
lines changed

src/converters/lintConfigs/rules/ruleConverters.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -163,6 +163,7 @@ import { convertNoConsole } from "./ruleConverters/no-console";
163163
import { convertNoConstantCondition } from "./ruleConverters/no-constant-condition";
164164
import { convertNoConstruct } from "./ruleConverters/no-construct";
165165
import { convertNoControlRegex } from "./ruleConverters/no-control-regex";
166+
import { convertNoCookies } from "./ruleConverters/no-cookies";
166167
import { convertNoDebugger } from "./ruleConverters/no-debugger";
167168
import { convertNoDefaultExport } from "./ruleConverters/no-default-export";
168169
import { convertNoDeleteExpression } from "./ruleConverters/no-delete-expression";
@@ -347,6 +348,7 @@ export const ruleConverters = new Map([
347348
["no-constant-condition", convertNoConstantCondition],
348349
["no-construct", convertNoConstruct],
349350
["no-control-regex", convertNoControlRegex],
351+
["no-cookies", convertNoCookies],
350352
["no-debugger", convertNoDebugger],
351353
["no-default-export", convertNoDefaultExport],
352354
["no-delete-expression", convertNoDeleteExpression],
Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
import { RuleConverter } from "../ruleConverter";
2+
3+
export const convertNoCookies: RuleConverter = () => {
4+
return {
5+
rules: [
6+
{
7+
ruleArguments: [
8+
{
9+
message: "Forbidden call to document.cookie",
10+
selector: 'MemberExpression[object.name="document"][property.name="cookie"]',
11+
}
12+
],
13+
ruleName: "restricted-syntax",
14+
},
15+
],
16+
};
17+
};
Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
import { convertNoCookies } from "../no-cookies";
2+
3+
describe(convertNoCookies, () => {
4+
test("conversion without arguments", () => {
5+
const result = convertNoCookies({
6+
ruleArguments: [],
7+
});
8+
9+
expect(result).toEqual({
10+
rules: [
11+
{
12+
ruleArguments: [
13+
{
14+
message: "Forbidden call to document.cookie",
15+
selector: 'MemberExpression[object.name="document"][property.name="cookie"]',
16+
}
17+
],
18+
ruleName: "restricted-syntax",
19+
},
20+
],
21+
});
22+
});
23+
});

0 commit comments

Comments
 (0)