Skip to content

Commit cdf8a69

Browse files
authored
Add no-unused-variable converter (#422)
* Add no-unused-variable converter * remove extra rule output on no-unused-variable
1 parent bb3ce0b commit cdf8a69

File tree

3 files changed

+36
-0
lines changed

3 files changed

+36
-0
lines changed
Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
import { RuleConverter } from "../converter";
2+
3+
export const NO_UNUSED_VARIABLE_NOTICE =
4+
"Please read the following article as the rule behaviour may change on the short term: " +
5+
"https://github.com/typescript-eslint/typescript-eslint/issues/1856";
6+
7+
export const convertNoUnusedVariable: RuleConverter = () => {
8+
return {
9+
rules: [
10+
{
11+
ruleName: "@typescript-eslint/no-unused-vars",
12+
notices: [NO_UNUSED_VARIABLE_NOTICE],
13+
},
14+
],
15+
};
16+
};
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
import { convertNoUnusedVariable, NO_UNUSED_VARIABLE_NOTICE } from "../no-unused-variable";
2+
3+
describe(convertNoUnusedVariable, () => {
4+
test("conversion without arguments", () => {
5+
const result = convertNoUnusedVariable({
6+
ruleArguments: [],
7+
});
8+
9+
expect(result).toEqual({
10+
rules: [
11+
{
12+
ruleName: "@typescript-eslint/no-unused-vars",
13+
notices: [NO_UNUSED_VARIABLE_NOTICE],
14+
},
15+
],
16+
});
17+
});
18+
});

src/rules/rulesConverters.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,7 @@ import { convertNoUnnecessarySemicolons } from "./converters/no-unnecessary-semi
9999
import { convertNoUnnecessaryTypeAssertion } from "./converters/no-unnecessary-type-assertion";
100100
import { convertNoUnsafeFinally } from "./converters/no-unsafe-finally";
101101
import { convertNoUnusedExpression } from "./converters/no-unused-expression";
102+
import { convertNoUnusedVariable } from "./converters/no-unused-variable";
102103
import { convertNoUseBeforeDeclare } from "./converters/no-use-before-declare";
103104
import { convertNoVarKeyword } from "./converters/no-var-keyword";
104105
import { convertNoVarRequires } from "./converters/no-var-requires";
@@ -241,6 +242,7 @@ export const rulesConverters = new Map([
241242
["no-unnecessary-type-assertion", convertNoUnnecessaryTypeAssertion],
242243
["no-unsafe-finally", convertNoUnsafeFinally],
243244
["no-unused-expression", convertNoUnusedExpression],
245+
["no-unused-variable", convertNoUnusedVariable],
244246
["no-use-before-declare", convertNoUseBeforeDeclare],
245247
["no-var-keyword", convertNoVarKeyword],
246248
["no-var-requires", convertNoVarRequires],

0 commit comments

Comments
 (0)