Fix Circle CI test step (#155)

* Fix circle ci test step

* Remove unnecessary arrow functions

* Sync test with implementation

* Fix converter

Author: cy6erskunk

.circleci/config.yml

@@ -91,7 +91,7 @@ jobs:
             - attach_workspace:
                   at: "."
 
-            - run: npm run test --coverage
+            - run: npm run test:unit
 
     tsc:
         docker:

src/errors/conversionError.test.ts

@@ -33,7 +33,7 @@ describe(ConversionError, () => {
 
             // Assert
             expect(summary).toEqual(
-                `Error: multiple output eslint-rule ESLint rule options were generated, but tslint-to-eslint-config doesn't have "merger" logic to deal with this.${EOL}Please file an issue at https://github.com/typescript-eslint/tslint-to-eslint-config/issues/new?template=bug_report.md!`,
+                `Error: multiple output eslint-rule ESLint rule options were generated, but tslint-to-eslint-config doesn't have "merger" logic to deal with this.${EOL}Please file an issue at https://github.com/typescript-eslint/tslint-to-eslint-config/issues/new?template=missing_merger.md 🙏`,
             );
         });
     });

src/errors/conversionError.ts

@@ -6,22 +6,22 @@ import { ErrorSummary } from "./errorSummary";
 export class ConversionError implements ErrorSummary {
     private constructor(private readonly summary: string) {}
 
-    public static forMerger = (eslintRule: string) => {
+    public static forMerger(eslintRule: string) {
         return new ConversionError(
             [
                 `Error: multiple output ${eslintRule} ESLint rule options were generated, but tslint-to-eslint-config doesn't have "merger" logic to deal with this.`,
                 `Please file an issue at https://github.com/typescript-eslint/tslint-to-eslint-config/issues/new?template=missing_merger.md 🙏`,
             ].join(EOL),
         );
-    };
+    }
 
     public getSummary(): string {
         return this.summary;
     }
 
-    public static forRuleError = (error: Error, tslintRule: TSLintRuleOptions) => {
+    public static forRuleError(error: Error, tslintRule: TSLintRuleOptions) {
         return new ConversionError(
             `${tslintRule.ruleName} threw an error during conversion: ${error.stack}${EOL}`,
         );
-    };
+    }
 }

src/rules/converters/member-ordering.ts

@@ -4,7 +4,7 @@ export const convertMemberOrdering: RuleConverter = () => {
     return {
         rules: [
             {
-                ruleName: "member-ordering",
+                ruleName: "@typescript-eslint/member-ordering",
             },
         ],
     };