Skip to content

Commit a0228c2

Browse files
KingDarBojaJosh Goldberg
and
Josh Goldberg
authored
Add codelyzer no-forward-ref converter (#529)
Co-authored-by: Josh Goldberg <joshuakgoldberg@outlook.com>
1 parent f9076e0 commit a0228c2

File tree

3 files changed

+33
-1
lines changed

3 files changed

+33
-1
lines changed
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
import { RuleConverter } from "../../converter";
2+
3+
export const convertNoForwardRef: RuleConverter = () => {
4+
return {
5+
rules: [
6+
{
7+
ruleName: "@angular-eslint/no-forward-ref",
8+
},
9+
],
10+
plugins: ["@angular-eslint/eslint-plugin"],
11+
};
12+
};
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
import { convertNoForwardRef } from "../no-forward-ref";
2+
3+
describe(convertNoForwardRef, () => {
4+
test("conversion without arguments", () => {
5+
const result = convertNoForwardRef({
6+
ruleArguments: [],
7+
});
8+
9+
expect(result).toEqual({
10+
rules: [
11+
{
12+
ruleName: "@angular-eslint/no-forward-ref",
13+
},
14+
],
15+
plugins: ["@angular-eslint/eslint-plugin"],
16+
});
17+
});
18+
});

src/rules/rulesConverters.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,6 +146,7 @@ import { convertDirectiveClassSuffix } from "./converters/codelyzer/directive-cl
146146
import { convertDirectiveSelector } from "./converters/codelyzer/directive-selector";
147147
import { convertNoAttributeDecorator } from "./converters/codelyzer/no-attribute-decorator";
148148
import { convertUsePipeDecorator } from "./converters/codelyzer/use-pipe-decorator";
149+
import { convertNoForwardRef } from "./converters/codelyzer/no-forward-ref";
149150
import { convertNoHostMetadataProperty } from "./converters/codelyzer/no-host-metadata-property";
150151

151152
/**
@@ -220,6 +221,7 @@ export const rulesConverters = new Map([
220221
["no-floating-promises", convertNoFloatingPromises],
221222
["no-for-in-array", convertNoForInArray],
222223
["no-for-in", convertNoForIn],
224+
["no-forward-ref", convertNoForwardRef],
223225
["no-host-metadata-property", convertNoHostMetadataProperty],
224226
["no-implicit-dependencies", convertNoImplicitDependencies],
225227
["no-import-side-effect", convertNoImportSideEffect],
@@ -240,8 +242,8 @@ export const rulesConverters = new Map([
240242
["no-parameter-properties", convertNoParameterProperties],
241243
["no-parameter-reassignment", convertNoParameterReassignment],
242244
["no-redundant-jsdoc", convertNoRedundantJsdoc],
243-
["no-reference", convertNoReference],
244245
["no-reference-import", convertNoReferenceImport],
246+
["no-reference", convertNoReference],
245247
["no-regex-spaces", convertNoRegexSpaces],
246248
["no-require-imports", convertNoRequireImports],
247249
["no-return-await", convertNoReturnAwait],

0 commit comments

Comments
 (0)