Skip to content

Commit 8ef52dd

Browse files
YashdalfTheGrayJosh Goldberg
authored and
Josh Goldberg
committed
added a converter for use-default-type-parameter (#221)
* added a converter fro use-default-type-parameter * code review changes
1 parent 5ec064b commit 8ef52dd

File tree

3 files changed

+30
-0
lines changed

3 files changed

+30
-0
lines changed

src/rules/converters.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,7 @@ import { convertTypeofCompare } from "./converters/typeof-compare";
109109
import { convertUnifiedSignatures } from "./converters/unified-signatures";
110110
import { convertUnnecessaryBind } from "./converters/unnecessary-bind";
111111
import { convertUnnecessaryConstructor } from "./converters/unnecessary-constructor";
112+
import { convertUseDefaultTypeParameter } from "./converters/use-default-type-parameter";
112113
import { convertUseIsnan } from "./converters/use-isnan";
113114
import { convertQuotemark } from "./converters/quotemark";
114115
import { convertTripleEquals } from "./converters/triple-equals";
@@ -230,6 +231,7 @@ export const converters = new Map([
230231
["unified-signatures", convertUnifiedSignatures],
231232
["unnecessary-bind", convertUnnecessaryBind],
232233
["unnecessary-constructor", convertUnnecessaryConstructor],
234+
["use-default-type-parameter", convertUseDefaultTypeParameter],
233235
["use-isnan", convertUseIsnan],
234236

235237
// These converters are all for rules that need more complex option conversions.
Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
import { convertUseDefaultTypeParameter } from "../use-default-type-parameter";
2+
3+
describe(convertUseDefaultTypeParameter, () => {
4+
test("conversion without arguments", () => {
5+
const result = convertUseDefaultTypeParameter({
6+
ruleArguments: [],
7+
});
8+
9+
expect(result).toEqual({
10+
rules: [
11+
{
12+
ruleName: "@typescript-eslint/no-unnecessary-type-arguments",
13+
},
14+
],
15+
});
16+
});
17+
});
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
import { RuleConverter } from "../converter";
2+
3+
export const convertUseDefaultTypeParameter: RuleConverter = () => {
4+
return {
5+
rules: [
6+
{
7+
ruleName: "@typescript-eslint/no-unnecessary-type-arguments",
8+
},
9+
],
10+
};
11+
};

0 commit comments

Comments
 (0)