Skip to content

Commit 665d38f

Browse files
author
Josh Goldberg
authored
Stopped logging package notice when none are missing (#446)
1 parent eb7ab20 commit 665d38f

File tree

2 files changed

+23
-0
lines changed

2 files changed

+23
-0
lines changed

src/reporting/packages/logMissingPackages.test.ts

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,25 @@ const createStubDependencies = (packageManager = PackageManager.npm) => ({
99
});
1010

1111
describe("logMissingPackages", () => {
12+
it("does nothing when no package are missing", async () => {
13+
// Arrange
14+
const { choosePackageManager, logger } = createStubDependencies(PackageManager.npm);
15+
const ruleConversionResults = createEmptyConversionResults();
16+
17+
// Act
18+
await logMissingPackages({ choosePackageManager, logger }, ruleConversionResults, {
19+
dependencies: {
20+
"@typescript-eslint/eslint-plugin": "*",
21+
"@typescript-eslint/parser": "*",
22+
eslint: "*",
23+
},
24+
devDependencies: {},
25+
});
26+
27+
// Assert
28+
expectEqualWrites(logger.stdout.write);
29+
});
30+
1231
it("reports a singular message when one package is missing", async () => {
1332
// Arrange
1433
const { choosePackageManager, logger } = createStubDependencies(PackageManager.npm);

src/reporting/packages/logMissingPackages.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,10 @@ export const logMissingPackages = async (
3939
.filter((packageName) => !existingPackageNames.has(packageName))
4040
.sort();
4141

42+
if (missingPackageNames.length === 0) {
43+
return;
44+
}
45+
4246
dependencies.logger.stdout.write(chalk.cyanBright(`${EOL}${missingPackageNames.length}`));
4347
dependencies.logger.stdout.write(
4448
chalk.cyan(

0 commit comments

Comments
 (0)