Skip to content

Commit 516d0e3

Browse files
author
Josh Goldberg
authored
Added missing output plugins to configuration file (#706)
1 parent b362fed commit 516d0e3

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

src/creation/writeConversionResults.test.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@ describe("writeConversionResults", () => {
6060
ruleSeverity: "error",
6161
},
6262
],
63+
plugins: new Set(["eslint-plugin-example"]),
6364
});
6465
const fileSystem = { writeFile: jest.fn().mockReturnValue(Promise.resolve()) };
6566

@@ -85,7 +86,11 @@ describe("writeConversionResults", () => {
8586
project: "tsconfig.json",
8687
sourceType: "module",
8788
},
88-
plugins: ["@typescript-eslint", "@typescript-eslint/tslint"],
89+
plugins: [
90+
"eslint-plugin-example",
91+
"@typescript-eslint",
92+
"@typescript-eslint/tslint",
93+
],
8994
rules: {
9095
"@typescript-eslint/tslint/config": [
9196
"error",

src/creation/writeConversionResults.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,11 @@ export const writeConversionResults = async (
1616
summarizedResults: SummarizedResultsConfiguration,
1717
originalConfigurations: AllOriginalConfigurations,
1818
) => {
19-
const plugins = ["@typescript-eslint"];
19+
const plugins = new Set([...summarizedResults.plugins, "@typescript-eslint"]);
2020
const { eslint, tslint } = originalConfigurations;
2121

2222
if (summarizedResults.missing.length !== 0) {
23-
plugins.push("@typescript-eslint/tslint");
23+
plugins.add("@typescript-eslint/tslint");
2424
}
2525

2626
const output = removeEmptyMembers({
@@ -33,7 +33,7 @@ export const writeConversionResults = async (
3333
project: "tsconfig.json",
3434
sourceType: "module",
3535
},
36-
plugins,
36+
plugins: Array.from(plugins),
3737
rules: formatConvertedRules(summarizedResults, tslint.full),
3838
});
3939

0 commit comments

Comments
 (0)