Skip to content

Commit 3f72f4d

Browse files
kbrillaKrzysztof BrillaJoshuaKGoldberg
authored
Adding the rule, mapping it and writing the tests (#807)
Co-authored-by: Krzysztof Brilla <brilla.krzysztof@gmail.com> Co-authored-by: Josh Goldberg <me@joshuakgoldberg.com>
1 parent c9f27b7 commit 3f72f4d

File tree

3 files changed

+32
-0
lines changed

3 files changed

+32
-0
lines changed

src/converters/lintConfigs/rules/ruleConverters.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -189,6 +189,7 @@ import { convertNoCreate } from "./ruleConverters/eslint-plugin-rxjs/no-create";
189189
import { convertNoIgnoredNotifier } from "./ruleConverters/eslint-plugin-rxjs/no-ignored-notifier";
190190
import { convertNoIgnoredReplayBuffer } from "./ruleConverters/eslint-plugin-rxjs/no-ignored-replay-buffer";
191191
import { convertNoIgnoredTakeWhileValue } from "./ruleConverters/eslint-plugin-rxjs/no-ignored-takewhile-value";
192+
import { convertNoIndex } from "./ruleConverters/eslint-plugin-rxjs/no-index";
192193
import { convertNoInternal } from "./ruleConverters/eslint-plugin-rxjs/no-internal";
193194
import { convertNoNestedSubscribe } from "./ruleConverters/eslint-plugin-rxjs/no-nested-subscribe";
194195
import { convertNoRedundantNotify } from "./ruleConverters/eslint-plugin-rxjs/no-redundant-notify";
@@ -388,6 +389,7 @@ export const ruleConverters = new Map([
388389
["rxjs-no-ignored-notifier", convertNoIgnoredNotifier],
389390
["rxjs-no-ignored-replay-buffer", convertNoIgnoredReplayBuffer],
390391
["rxjs-no-ignored-takewhile-value", convertNoIgnoredTakeWhileValue],
392+
["rxjs-no-index", convertNoIndex],
391393
["rxjs-no-internal", convertNoInternal],
392394
["rxjs-no-nested-subscribe", convertNoNestedSubscribe],
393395
["rxjs-no-redundant-notify", convertNoRedundantNotify],
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
import { RuleConverter } from "../../ruleConverter";
2+
3+
export const convertNoIndex: RuleConverter = () => {
4+
return {
5+
rules: [
6+
{
7+
ruleName: "rxjs/no-index",
8+
},
9+
],
10+
plugins: ["eslint-plugin-rxjs"],
11+
};
12+
};
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
import { convertNoIndex } from "../no-index";
2+
3+
describe(convertNoIndex, () => {
4+
test("conversion without arguments", () => {
5+
const result = convertNoIndex({
6+
ruleArguments: [],
7+
});
8+
9+
expect(result).toEqual({
10+
rules: [
11+
{
12+
ruleName: "rxjs/no-index",
13+
},
14+
],
15+
plugins: ["eslint-plugin-rxjs"],
16+
});
17+
});
18+
});

0 commit comments

Comments
 (0)