Skip to content

Commit 3d8ded3

Browse files
committed
Check whether a rule is array object or not on ban-types converter
1 parent e6b2f61 commit 3d8ded3

File tree

2 files changed

+18
-0
lines changed

2 files changed

+18
-0
lines changed

src/rules/converters/ban-types.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,10 @@ export const convertBanTypes: RuleConverter = tslintRule => {
88
const bannedTypes: Record<string, ConvertBanTypeArgument | null> = {};
99

1010
for (const rule of tslintRule.ruleArguments) {
11+
if (!Array.isArray(rule)) {
12+
break;
13+
}
14+
1115
const [bannedType, message] = rule;
1216
if (!bannedType) {
1317
break;

src/rules/converters/tests/ban-types.test.ts

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,4 +69,18 @@ describe(convertBanTypes, () => {
6969
],
7070
});
7171
});
72+
73+
test("conversion with duplicated arguments", () => {
74+
const result = convertBanTypes({
75+
ruleArguments: ["!!!this-is-not-array!!!"],
76+
});
77+
78+
expect(result).toEqual({
79+
rules: [
80+
{
81+
ruleName: "@typescript-eslint/ban-types",
82+
},
83+
],
84+
});
85+
});
7286
});

0 commit comments

Comments
 (0)