Skip to content

Commit 1689af3

Browse files
HolgerJerominJosh Goldberg
authored and
Josh Goldberg
committed
Output optimizing for unsupported rules (#236)
* Update reportConversionResults.test.ts * Update reportConversionResults.ts * updated test for single rule output
1 parent f72b6b1 commit 1689af3

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/reporting/reportConversionResults.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ describe("reportConversionResults", () => {
167167
// Assert
168168
expectEqualWrites(
169169
logger.stdout.write,
170-
"👀 1 rule does not yet have an ESLint equivalent; defaulting to eslint-plugin-tslint. 👀",
170+
"👀 1 rule does not yet have an ESLint equivalent (see generated log file); defaulting to eslint-plugin-tslint for these rules. 👀",
171171
);
172172
expectEqualWrites(
173173
logger.info.write,
@@ -200,7 +200,7 @@ describe("reportConversionResults", () => {
200200
// Assert
201201
expectEqualWrites(
202202
logger.stdout.write,
203-
"👀 2 rules do not yet have ESLint equivalents; defaulting to eslint-plugin-tslint. 👀",
203+
"👀 2 rules do not yet have ESLint equivalents (see generated log file); defaulting to eslint-plugin-tslint for these rules. 👀",
204204
);
205205
expectEqualWrites(
206206
logger.info.write,

src/reporting/reportConversionResults.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ const logMissingRules = (missing: TSLintRuleOptions[], logger: Logger) => {
6262
: " rules do not yet have ESLint equivalents",
6363
),
6464
);
65-
logger.stdout.write(chalk.yellow("; defaulting to eslint-plugin-tslint."));
65+
logger.stdout.write(chalk.yellow(" (see generated log file); defaulting to eslint-plugin-tslint for these rules."));
6666
logger.stdout.write(chalk.yellowBright(` 👀${EOL}`));
6767

6868
logger.info.write(

0 commit comments

Comments
 (0)