Skip to content

Commit 0f69d9d

Browse files
authored
Fix arrow-parens converter (#347)
1 parent 18ffe46 commit 0f69d9d

File tree

2 files changed

+6
-20
lines changed

2 files changed

+6
-20
lines changed

src/rules/converters/arrow-parens.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,10 @@ import { RuleConverter } from "../converter";
22

33
export const convertArrowParens: RuleConverter = tslintRule => {
44
const ruleArguments = [
5-
tslintRule.ruleArguments.length !== 0 && tslintRule.ruleArguments[0] === "always"
6-
? "always"
7-
: "as-needed",
5+
tslintRule.ruleArguments.length !== 0 &&
6+
tslintRule.ruleArguments[0] === "ban-single-arg-parens"
7+
? "as-needed"
8+
: "always",
89
];
910

1011
return {

src/rules/converters/tests/arrow-parens.test.ts

Lines changed: 2 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -6,21 +6,6 @@ describe(convertArrowParens, () => {
66
ruleArguments: [],
77
});
88

9-
expect(result).toEqual({
10-
rules: [
11-
{
12-
ruleArguments: ["as-needed"],
13-
ruleName: "arrow-parens",
14-
},
15-
],
16-
});
17-
});
18-
19-
test("conversion with an always argument", () => {
20-
const result = convertArrowParens({
21-
ruleArguments: ["always"],
22-
});
23-
249
expect(result).toEqual({
2510
rules: [
2611
{
@@ -31,9 +16,9 @@ describe(convertArrowParens, () => {
3116
});
3217
});
3318

34-
test("conversion with an as-needed argument", () => {
19+
test("conversion with a ban-single-arg-parens argument", () => {
3520
const result = convertArrowParens({
36-
ruleArguments: ["as-needed"],
21+
ruleArguments: ["ban-single-arg-parens"],
3722
});
3823

3924
expect(result).toEqual({

0 commit comments

Comments
 (0)