add no-import-side-effect converter

Author: bmeverett

src/rules/converters/no-import-side-effect.ts

@@ -0,0 +1,21 @@
+import { RuleConverter } from "../converter";
+
+export const convertNoImportSideEffect: RuleConverter = tsLintRule => {
+    const rules = [];
+    const notices = [];
+
+    if (tsLintRule.ruleArguments.length > 0) {
+        rules.push({ allow: tsLintRule.ruleArguments[1]["ignore-module"] });
+        notices.push("This now accepts a glob pattern, so your regex may need converted");
+    }
+
+    return {
+        rules: [
+            {
+                ruleArguments: rules,
+                ruleName: "no-import-side-effect",
+                notices: notices,
+            },
+        ],
+    };
+};

src/rules/converters/tests/no-import-side-effect.test.ts

@@ -0,0 +1,35 @@
+import { convertNoImportSideEffect } from "../no-import-side-effect";
+
+describe(convertNoImportSideEffect, () => {
+    test("conversion without arguments", () => {
+        const result = convertNoImportSideEffect({
+            ruleArguments: [],
+        });
+
+        expect(result).toEqual({
+            rules: [
+                {
+                    ruleArguments: [],
+                    ruleName: "no-import-side-effect",
+                    notices: [],
+                },
+            ],
+        });
+    });
+
+    test("conversion with arguments", () => {
+        const result = convertNoImportSideEffect({
+            ruleArguments: [true, { "ignore-module": "(\\.html|\\.css)$" }],
+        });
+
+        expect(result).toEqual({
+            rules: [
+                {
+                    ruleArguments: [{ allow: "(\\.html|\\.css)$" }],
+                    ruleName: "no-import-side-effect",
+                    notices: ["This now accepts a glob pattern, so your regex may need converted"],
+                },
+            ],
+        });
+    });
+});