Update typescript-eslint monorepo to v4 (major) (#697)

* Update typescript-eslint monorepo to v4

* Disable @typescript-eslint/consistent-type-imports

* Shadows; disable @typescript-eslint/no-implicit-any-catch too

Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Josh Goldberg <me@joshuakgoldberg.com>

Author: 3 people

.eslintrc.js

@@ -20,13 +20,15 @@ module.exports = {
     rules: {
         "@typescript-eslint/require-array-sort-compare": "off",
         "@typescript-eslint/consistent-type-definitions": ["error", "type"],
+        "@typescript-eslint/consistent-type-imports": "off",
         "@typescript-eslint/explicit-function-return-type": "off",
         "@typescript-eslint/explicit-module-boundary-types": "off",
         "@typescript-eslint/generic-type-naming": "off",
         "@typescript-eslint/naming-convention": "off",
         "@typescript-eslint/init-declarations": "off",
         "@typescript-eslint/method-signature-style": "off",
         "@typescript-eslint/no-explicit-any": "off",
+        "@typescript-eslint/no-implicit-any-catch": "off",
         "@typescript-eslint/no-magic-numbers": "off",
         "@typescript-eslint/no-parameter-properties": "off",
         "@typescript-eslint/no-type-alias": "off",

package-lock.json

@@ -28,8 +28,8 @@
         "@types/glob": "7.1.3",
         "@types/jest": "26.0.13",
         "@types/node": "12.12.21",
-        "@typescript-eslint/eslint-plugin": "3.9.1",
-        "@typescript-eslint/parser": "3.9.1",
+        "@typescript-eslint/eslint-plugin": "4.1.0",
+        "@typescript-eslint/parser": "4.1.0",
         "babel-jest": "26.3.0",
         "eslint": "7.8.1",
         "husky": "4.3.0",

package.json

@@ -44,8 +44,8 @@ export const runCli = async (
         return ResultStatus.Succeeded;
     }
 
-    for (const convertConfig of dependencies.convertConfigs) {
-        const result = await tryConvertConfig(convertConfig, parsedArgv);
+    for (const configConverter of dependencies.convertConfigs) {
+        const result = await tryConvertConfig(configConverter, parsedArgv);
         if (result.status !== ResultStatus.Succeeded) {
             logErrorResult(result, dependencies);
             return result.status;
@@ -57,13 +57,13 @@ export const runCli = async (
 };
 
 const tryConvertConfig = async (
-    config: SansDependencies<typeof convertConfig>,
+    configConverter: SansDependencies<typeof convertConfig>,
     argv: Partial<TSLintToESLintSettings>,
 ): Promise<ResultWithStatus> => {
     let result: ResultWithStatus;
 
     try {
-        result = await config(argv as TSLintToESLintSettings);
+        result = await configConverter(argv as TSLintToESLintSettings);
     } catch (error) {
         result = {
             errors: [error as Error],

src/cli/runCli.ts

@@ -27,7 +27,7 @@ export const logFailedConversions = (failed: ErrorSummary[], logger: Logger) =>
     logger.stderr.write(chalk.red(` error${failed.length === 1 ? "" : "s"}`));
     logger.stderr.write(chalk.red(" thrown."));
     logger.stderr.write(chalk.redBright(` ❌${EOL}`));
-    logger.info.write(failed.map((failed) => failed.getSummary()).join("\n\n") + "\n\n");
+    logger.info.write(failed.map((fail) => fail.getSummary()).join("\n\n") + "\n\n");
     logger.stderr.write(chalk.red(`  Check ${logger.debugFileName} for details.${EOL}`));
 };