From 92fed19788881ac26c57114e75226306b48894a5 Mon Sep 17 00:00:00 2001 From: abhiram6121 <142340683+abhiram6121@users.noreply.github.com> Date: Mon, 14 Oct 2024 16:28:25 +0530 Subject: [PATCH 1/2] chore: Update `actions/setup-node` to `v4` - Bump node version to 20.x (https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default) - Read node version directly from `.nvmrc` file using the `node-version-file` command (https://github.com/actions/setup-node/blob/main/docs/advanced-usage.md#node-version-file) --- .github/workflows/main.yml | 8 ++------ .nvmrc | 2 +- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 1fdb2bd97..ff6d7b393 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -12,14 +12,10 @@ jobs: - name: Checkout commit uses: actions/checkout@v4 - - name: Read .nvmrc - run: echo "NVMRC=$(cat .nvmrc)" >> $GITHUB_OUTPUT - id: nvm - - name: Setup node - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: - node-version: "${{ steps.nvm.outputs.NVMRC }}" + node-version-file: '.nvmrc' cache: yarn - name: Install dependencies diff --git a/.nvmrc b/.nvmrc index d9289897d..922f10a16 100644 --- a/.nvmrc +++ b/.nvmrc @@ -1 +1 @@ -16.15.1 +20.x From 81fb7b9996baf1815cb30747acafa98f3ebb838b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Filip=20Tammerg=C3=A5rd?= <44197016+filiptammergard@users.noreply.github.com> Date: Mon, 14 Oct 2024 22:09:50 +0200 Subject: [PATCH 2/2] Update main.yml --- .github/workflows/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index ff6d7b393..392465cf8 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -15,7 +15,7 @@ jobs: - name: Setup node uses: actions/setup-node@v4 with: - node-version-file: '.nvmrc' + node-version-file: ".nvmrc" cache: yarn - name: Install dependencies