Skip to content

Commit 45c246f

Browse files
authored
Fixed a mistake in the narrowingDestructuring test (microsoft#52411)
1 parent a311e25 commit 45c246f

File tree

4 files changed

+13
-9
lines changed

4 files changed

+13
-9
lines changed

tests/baselines/reference/narrowingDestructuring.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,11 @@ function func3<T extends { kind: "a", a: string } | { kind: "b", b: number }>(t:
3434

3535
function farr<T extends [number, string, string] | [string, number, number]>(x: T) {
3636
const [head, ...tail] = x;
37-
if (x[0] === 'number') {
37+
if (typeof x[0] === 'number') {
3838
const [head, ...tail] = x;
3939
}
40-
}
40+
}
41+
4142

4243
//// [narrowingDestructuring.js]
4344
var __rest = (this && this.__rest) || function (s, e) {
@@ -83,7 +84,7 @@ function func3(t) {
8384
}
8485
function farr(x) {
8586
var head = x[0], tail = x.slice(1);
86-
if (x[0] === 'number') {
87+
if (typeof x[0] === 'number') {
8788
var head_1 = x[0], tail_1 = x.slice(1);
8889
}
8990
}

tests/baselines/reference/narrowingDestructuring.symbols

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ function farr<T extends [number, string, string] | [string, number, number]>(x:
136136
>tail : Symbol(tail, Decl(narrowingDestructuring.ts, 34, 16))
137137
>x : Symbol(x, Decl(narrowingDestructuring.ts, 33, 77))
138138

139-
if (x[0] === 'number') {
139+
if (typeof x[0] === 'number') {
140140
>x : Symbol(x, Decl(narrowingDestructuring.ts, 33, 77))
141141
>0 : Symbol(0)
142142

@@ -146,3 +146,4 @@ function farr<T extends [number, string, string] | [string, number, number]>(x:
146146
>x : Symbol(x, Decl(narrowingDestructuring.ts, 33, 77))
147147
}
148148
}
149+

tests/baselines/reference/narrowingDestructuring.types

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -135,16 +135,18 @@ function farr<T extends [number, string, string] | [string, number, number]>(x:
135135
>tail : [string, string] | [number, number]
136136
>x : [number, string, string] | [string, number, number]
137137

138-
if (x[0] === 'number') {
139-
>x[0] === 'number' : boolean
138+
if (typeof x[0] === 'number') {
139+
>typeof x[0] === 'number' : boolean
140+
>typeof x[0] : "string" | "number" | "bigint" | "boolean" | "symbol" | "undefined" | "object" | "function"
140141
>x[0] : string | number
141142
>x : [number, string, string] | [string, number, number]
142143
>0 : 0
143144
>'number' : "number"
144145

145146
const [head, ...tail] = x;
146-
>head : "number"
147+
>head : number
147148
>tail : [string, string] | [number, number]
148149
>x : [number, string, string] | [string, number, number]
149150
}
150151
}
152+

tests/cases/compiler/narrowingDestructuring.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ function func3<T extends { kind: "a", a: string } | { kind: "b", b: number }>(t:
3333

3434
function farr<T extends [number, string, string] | [string, number, number]>(x: T) {
3535
const [head, ...tail] = x;
36-
if (x[0] === 'number') {
36+
if (typeof x[0] === 'number') {
3737
const [head, ...tail] = x;
3838
}
39-
}
39+
}

0 commit comments

Comments
 (0)