Skip to content

Commit e67edc0

Browse files
cacocojenkins
authored and
jenkins
committed
Revert to scala 2.12.12 due to scoverage issue with scala 2.12.13
Problem/Solution The scoverage plugin has an issue due to a binary incompatibility introduced in scala 2.12.13 (see: scoverage/sbt-scoverage#319). It has been patched in the plugin in scoverage/scalac-scoverage-plugin#306 which is currently awaiting a release. However after updating our projects to scala 2.12.13, coverage is broken and failing the CI builds. Downgrade to scala 2.12.12 until the scoverage plugin has been published with the fix. Differential Revision: https://phabricator.twitter.biz/D635917
1 parent 4a4d614 commit e67edc0

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

.github/workflows/continuous-integration.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
strategy:
2020
fail-fast: false
2121
matrix:
22-
scala: [2.12.13, 2.13.1]
22+
scala: [2.12.12, 2.13.1]
2323
java: ['1.8', '1.11']
2424
runs-on: ubuntu-latest
2525
steps:

CHANGELOG.rst

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,9 @@ Unreleased
1010
Runtime Behavior Changes
1111
~~~~~~~~~~~~~~~~~~~~~~~~
1212

13+
* scrooge: Revert to scala version 2.12.12 due to https://github.com/scoverage/sbt-scoverage/issues/319
14+
``PHAB_ID=D635917``
15+
1316
* scrooge: Bump scala version to 2.12.13 ``PHAB_ID=D632567``
1417

1518
Breaking API Changes

build.sbt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -185,8 +185,8 @@ val settingsWithTwoTen =
185185
val settingsCrossCompiledWithTwoTen =
186186
sharedSettingsWithoutScalaVersion ++
187187
Seq(
188-
crossScalaVersions := Seq("2.10.7", "2.11.12", "2.12.13", "2.13.1"),
189-
scalaVersion := "2.12.13",
188+
crossScalaVersions := Seq("2.10.7", "2.11.12", "2.12.12", "2.13.1"),
189+
scalaVersion := "2.12.12",
190190
scalacOptions := scalacTwoTenOptions,
191191
javacOptions ++= Seq("-source", "1.8", "-target", "1.8", "-Xlint:unchecked"),
192192
javacOptions in doc := Seq("-source", "1.8")

0 commit comments

Comments
 (0)