Skip to content

Commit ec2e1ce

Browse files
author
Attila Jeges
committed
Stop building manylinux wheels
Wheels built in a CentOS-based manylinux docker container won't work on Debian/Ubuntu Linux. This happens because the wheels contain the libsasl2.so library which is not portable across Linux distributions. As far as I know there's no way to build CentOS-only wheels so for now the safest thing to do is to stop distributing wheels and keep the source distribution only.
1 parent 0726b4a commit ec2e1ce

File tree

1 file changed

+0
-55
lines changed

1 file changed

+0
-55
lines changed

io/manylinux/build.sh

Lines changed: 0 additions & 55 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,6 @@ PKG_NAME=sasl
2727
GIT_REPO="python-sasl"
2828
GIT_URL="https://github.com/${GITHUB_ACCOUNT}/${GIT_REPO}.git"
2929

30-
BDIST_TMP_DIR="${PIP_DISTS_BUILD_DIR}/tmp"
31-
WHEELHOUSE_DIR="${PIP_DISTS_BUILD_DIR}/wheelhouse"
3230
SDIST_DIR="${PIP_DISTS_BUILD_DIR}/sdist"
3331

3432
SYSTEM_REQUIREMENTS=(cyrus-sasl cyrus-sasl-devel)
@@ -56,37 +54,6 @@ is_cpython2() {
5654
[[ "$pyver_abi" =~ ^cp2 ]]
5755
}
5856

59-
build_wheels() {
60-
# Compile wheels for all python versions
61-
local pydir=""
62-
local wheel_path=""
63-
for pydir in /opt/python/*; do
64-
# Do not build wheels for cpython2
65-
local pyver_abi="$(basename $pydir)"
66-
if is_cpython2 "$pyver_abi"; then continue; fi
67-
68-
echo "Building wheel with $(${pydir}/bin/python -V 2>&1)"
69-
"${pydir}/bin/python" setup.py bdist_wheel -d "$BDIST_TMP_DIR"
70-
wheel_path="$(ls ${BDIST_TMP_DIR}/*.whl)"
71-
done
72-
73-
if [ -z "wheel_path" ]; then
74-
echo "Failed building wheels. Couldn't find python>=3.0"
75-
exit 1
76-
fi
77-
}
78-
79-
repair_wheels() {
80-
# Bundle external shared libraries into the wheels
81-
for whl in "${BDIST_TMP_DIR}/"*.whl; do
82-
auditwheel repair $whl -w "$WHEELHOUSE_DIR"
83-
done
84-
}
85-
86-
show_wheels() {
87-
ls -l "${WHEELHOUSE_DIR}/"*.whl
88-
}
89-
9057
build_sdist() {
9158
local pydir=""
9259
local sdist_path=""
@@ -160,32 +127,10 @@ EOF
160127
python /tmp/sanity_check.py
161128
tear_down_virt_env
162129
done
163-
164-
# Install wheels with different python versions and run sanity_check.
165-
# System requirements can be removed as the wheels should already include them.
166-
yum remove -y "${SYSTEM_REQUIREMENTS[@]}"
167-
yum remove -y "${BUILD_REQUIREMENTS[@]}"
168-
169-
for pydir in /opt/python/*; do
170-
# Haven't built wheels for cpython2, skip cpython2 testing
171-
local pyver_abi="$(basename $pydir)"
172-
if is_cpython2 "$pyver_abi"; then continue; fi
173-
174-
local whlfn="$(ls ${WHEELHOUSE_DIR}/${PKG_NAME}-*-${pyver_abi}-*.whl)"
175-
176-
set_up_virt_env "$pydir"
177-
pip install --no-cache-dir --only-binary "$PKG_NAME" "$whlfn"
178-
python /tmp/sanity_check.py
179-
tear_down_virt_env
180-
done
181130
}
182131

183132
prepare_system
184133

185-
build_wheels
186-
repair_wheels
187-
show_wheels
188-
189134
build_sdist
190135
show_sdist
191136

0 commit comments

Comments
 (0)