Skip to content

Commit dd0fdb9

Browse files
committed
fix: validation of "tags"
ref issue #854
1 parent f6a2342 commit dd0fdb9

File tree

1 file changed

+12
-3
lines changed

1 file changed

+12
-3
lines changed

src/components/ChallengeEditor/index.js

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -639,15 +639,24 @@ class ChallengeEditor extends Component {
639639
return false
640640
}
641641

642-
return !(Object.values(pick([
642+
const requiredFields = [
643643
'trackId',
644644
'typeId',
645645
'name',
646646
'description',
647647
'tags',
648648
'prizeSets'
649-
], challenge)).filter(v => !v.length).length ||
650-
_.isEmpty(this.state.currentTemplate))
649+
]
650+
let isRequiredMissing = false
651+
652+
requiredFields.forEach((key) => {
653+
const value = challenge[key]
654+
655+
// this check works for string and array values
656+
isRequiredMissing = isRequiredMissing || !value || !value.length
657+
})
658+
659+
return !(isRequiredMissing || _.isEmpty(this.state.currentTemplate))
651660
}
652661

653662
validateChallenge () {

0 commit comments

Comments
 (0)