Skip to content

Commit ad1ed4a

Browse files
committed
fix issue 1357
1 parent eea2876 commit ad1ed4a

File tree

3 files changed

+25
-20
lines changed

3 files changed

+25
-20
lines changed

src/components/ChallengeEditor/index.js

Lines changed: 15 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -820,23 +820,25 @@ class ChallengeEditor extends Component {
820820
newChallenge.phases[index]['scheduledEndDate'] = phase.endDate
821821

822822
let lastDate = phase.endDate
823-
for (let phaseIndex = index + 1; phaseIndex < phases.length; phaseIndex++) {
824-
if (moment(phases[phaseIndex]['scheduledStartDate']).isBefore(lastDate)) {
825-
lastDate = moment(lastDate).add('1', 'hour').format('MM/DD/YYYY HH:mm')
823+
for (let phaseIndex = 0; phaseIndex < phases.length; phaseIndex++) {
824+
if (phaseIndex !== index) {
825+
if (moment(phases[phaseIndex]['scheduledStartDate']).isBefore(lastDate)) {
826+
lastDate = moment(lastDate).add('1', 'hour').format('MM/DD/YYYY HH:mm')
826827

827-
if (newChallenge.phases[phaseIndex]['name'] !== 'Submission') {
828-
newChallenge.phases[phaseIndex]['scheduledStartDate'] = lastDate
829-
} else {
830-
newChallenge.phases[phaseIndex]['scheduledStartDate'] = newChallenge.phases[index]['scheduledStartDate']
831-
}
828+
if (newChallenge.phases[phaseIndex]['name'] !== 'Submission') {
829+
newChallenge.phases[phaseIndex]['scheduledStartDate'] = lastDate
830+
} else {
831+
newChallenge.phases[phaseIndex]['scheduledStartDate'] = newChallenge.phases[index]['scheduledStartDate']
832+
}
832833

833-
if (moment(phases[phaseIndex]['scheduledEndDate']).isBefore(lastDate)) {
834-
lastDate = moment(lastDate).add('1', 'hour').format('MM/DD/YYYY HH:mm')
835-
newChallenge.phases[phaseIndex]['scheduledEndDate'] = lastDate
836-
}
834+
if (moment(phases[phaseIndex]['scheduledEndDate']).isBefore(lastDate)) {
835+
lastDate = moment(lastDate).add('1', 'hour').format('MM/DD/YYYY HH:mm')
836+
newChallenge.phases[phaseIndex]['scheduledEndDate'] = lastDate
837+
}
837838

838-
newChallenge.phases[phaseIndex]['duration'] =
839+
newChallenge.phases[phaseIndex]['duration'] =
839840
moment(newChallenge.phases[phaseIndex]['scheduledEndDate']).diff(newChallenge.phases[phaseIndex]['scheduledStartDate'], 'hours')
841+
}
840842
}
841843
}
842844

src/components/DurationInput/DurationInput.module.scss

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,14 @@
55
cursor: not-allowed !important;
66
background-color: $inactive !important;
77
}
8+
9+
&::-webkit-outer-spin-button,
10+
&::-webkit-inner-spin-button {
11+
-webkit-appearance: none;
12+
margin: 0;
13+
}
14+
15+
&[type=number] {
16+
-moz-appearance: textfield;
17+
}
818
}

src/components/PhaseInput/index.js

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -27,13 +27,6 @@ const PhaseInput = ({ onUpdatePhase, phase, readOnly, phaseIndex, isActive }) =>
2727
setEndDate(phase.scheduledEndDate)
2828
setDuration(moment(phase.scheduledEndDate).diff(phase.scheduledStartDate, 'hours'))
2929
}
30-
}, [])
31-
32-
useEffect(() => {
33-
if (phase) {
34-
setStartDate(phase.scheduledStartDate)
35-
setEndDate(phase.scheduledEndDate)
36-
}
3730
}, [phase])
3831

3932
useEffect(() => {

0 commit comments

Comments
 (0)