Skip to content

Commit 6a8e165

Browse files
committed
fix project terms load and default terms in beta
1 parent de55c10 commit 6a8e165

File tree

2 files changed

+20
-5
lines changed

2 files changed

+20
-5
lines changed

src/components/ChallengeEditor/index.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -810,7 +810,8 @@ class ChallengeEditor extends Component {
810810

811811
async createNewChallenge () {
812812
if (!this.props.isNew) return
813-
const { metadata, createChallenge, projectDetail } = this.props
813+
const { metadata, createChallenge, projectDetail, location } = this.props
814+
const params = new URLSearchParams(location.search)
814815
const { name, trackId, typeId } = this.state.challenge
815816
const { timelineTemplates } = metadata
816817
const isDesignChallenge = trackId === DES_TRACK_ID
@@ -839,7 +840,7 @@ class ChallengeEditor extends Component {
839840
terms: [{ id: DEFAULT_TERM_UUID, roleId: SUBMITTER_ROLE_UUID }]
840841
// prizeSets: this.getDefaultPrizeSets()
841842
}
842-
if (projectDetail.terms) {
843+
if (params.get('beta') === 'true' && projectDetail.terms) {
843844
const currTerms = new Set(newChallenge.terms.map(term => term.id))
844845
newChallenge.terms.push(
845846
...projectDetail.terms

src/containers/ChallengeEditor/index.js

Lines changed: 17 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,8 @@ import {
3030
replaceResourceInRole
3131
} from '../../actions/challenges'
3232

33+
import { loadProject } from '../../actions/projects'
34+
3335
import { connect } from 'react-redux'
3436
import { SUBMITTER_ROLE_UUID, MESSAGE } from '../../config/constants'
3537
import { patchChallenge } from '../../services/challenges'
@@ -74,7 +76,8 @@ class ChallengeEditor extends Component {
7476
loadGroups,
7577
loadResourceRoles,
7678
loadChallengeDetails,
77-
loadResources
79+
loadResources,
80+
loadProject
7881
} = this.props
7982
loadTimelineTemplates()
8083
loadChallengePhases()
@@ -85,6 +88,7 @@ class ChallengeEditor extends Component {
8588
// loadChallengeTerms()
8689
loadGroups()
8790
loadResourceRoles()
91+
this.fetchProjectDetails(match, loadProject)
8892
this.fetchChallengeDetails(match, loadChallengeDetails, loadResources)
8993

9094
// this.unlisten = this.props.history.listen(() => {
@@ -112,6 +116,14 @@ class ChallengeEditor extends Component {
112116
}
113117
}
114118

119+
async fetchProjectDetails (newMatch, loadProject) {
120+
let projectId = _.get(newMatch.params, 'projectId', null)
121+
projectId = projectId ? parseInt(projectId) : null
122+
if (projectId) {
123+
await loadProject(projectId)
124+
}
125+
}
126+
115127
async fetchChallengeDetails (newMatch, loadChallengeDetails, loadResources) {
116128
let projectId = _.get(newMatch.params, 'projectId', null)
117129
projectId = projectId ? parseInt(projectId) : null
@@ -413,7 +425,8 @@ ChallengeEditor.propTypes = {
413425
partiallyUpdateChallengeDetails: PropTypes.func.isRequired,
414426
createChallenge: PropTypes.func.isRequired,
415427
deleteChallenge: PropTypes.func.isRequired,
416-
replaceResourceInRole: PropTypes.func
428+
replaceResourceInRole: PropTypes.func,
429+
loadProject: PropTypes.func
417430
// members: PropTypes.arrayOf(PropTypes.shape())
418431
}
419432

@@ -450,7 +463,8 @@ const mapDispatchToProps = {
450463
partiallyUpdateChallengeDetails,
451464
deleteChallenge,
452465
createChallenge,
453-
replaceResourceInRole
466+
replaceResourceInRole,
467+
loadProject
454468
}
455469

456470
export default withRouter(connect(mapStateToProps, mapDispatchToProps)(ChallengeEditor))

0 commit comments

Comments
 (0)