Skip to content

Commit 6247a54

Browse files
committed
review fixes
1 parent 45900cd commit 6247a54

File tree

2 files changed

+9
-80
lines changed

2 files changed

+9
-80
lines changed

src/components/ChallengeEditor/NDAField/NDAField.module.scss

Lines changed: 7 additions & 72 deletions
Original file line numberDiff line numberDiff line change
@@ -8,78 +8,13 @@
88
align-content: space-between;
99
justify-content: flex-start;
1010

11-
.tcCheckbox {
12-
@include tc-checkbox;
13-
14-
height: 18px;
15-
width: 210px;
16-
margin: 0;
17-
padding: 0;
18-
vertical-align: bottom;
19-
position: relative;
20-
display: inline-block;
21-
22-
input[type='checkbox'] {
23-
display: none;
24-
}
25-
26-
label {
27-
@include roboto-light();
28-
29-
line-height: 17px;
30-
font-weight: 300;
31-
cursor: pointer;
32-
position: absolute;
33-
display: inline-block;
34-
width: 14px;
35-
height: 14px;
36-
top: 0;
37-
left: 0;
38-
border: none;
39-
box-shadow: none;
40-
background: $tc-gray-30;
41-
transition: all 0.15s ease-in-out;
42-
43-
44-
&.readOnly {
45-
cursor: auto;
46-
}
47-
48-
&::after {
49-
opacity: 0;
50-
content: '';
51-
position: absolute;
52-
width: 9px;
53-
height: 5px;
54-
background: transparent;
55-
top: 2px;
56-
left: 2px;
57-
border-top: none;
58-
border-right: none;
59-
transform: rotate(-45deg);
60-
transition: all 0.15s ease-in-out;
61-
}
62-
63-
&:hover::after {
64-
opacity: 0.3;
65-
}
66-
&:hover:read-only::after {
67-
opacity: 0;
68-
}
69-
70-
div {
71-
margin-left: 24px;
72-
width: 300px;
73-
}
74-
}
75-
76-
input[type='checkbox']:checked ~ label {
77-
background: $tc-blue-20;
78-
}
79-
80-
input[type='checkbox']:checked + label::after {
81-
border-color: $white;
82-
}
11+
.fieldTitle {
12+
@include roboto-bold();
13+
font-size: 16px;
14+
line-height: 19px;
15+
font-weight: 500;
16+
color: $tc-gray-80;
17+
margin-right: 10px;
8318
}
8419

8520
.field {

src/components/ChallengeEditor/NDAField/index.js

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,7 @@ const NDAField = ({ challenge, toggleNdaRequire, readOnly }) => {
1313
<div className={styles.row}>
1414
<div className={cn(styles.field, styles.col1, styles.fieldTitle)}>NDA Required :</div>
1515
<div className={cn(styles.field, styles.col2)}>
16-
{
17-
isRequiredNda
18-
? <div>Yes</div>
19-
: <div>No</div>
20-
}
16+
{ isRequiredNda ? 'Yes' : 'No' }
2117
</div>
2218
</div>
2319
)
@@ -36,8 +32,7 @@ const NDAField = ({ challenge, toggleNdaRequire, readOnly }) => {
3632
onChange={toggleNdaRequire}
3733
/>
3834
<label className={styles['tc-RadioButton-label']} htmlFor='nda-yes'>
39-
<div>yes</div>
40-
<input type='hidden' />
35+
<div>Yes</div>
4136
</label>
4237
</div>
4338
<div className={styles.tcRadioButton}>
@@ -50,7 +45,6 @@ const NDAField = ({ challenge, toggleNdaRequire, readOnly }) => {
5045
/>
5146
<label className={styles['tc-RadioButton-label']} htmlFor='nda-no'>
5247
<div>No</div>
53-
<input type='hidden' />
5448
</label>
5549
</div>
5650
</div>

0 commit comments

Comments
 (0)