Better business rules for deleting users - don’t delete submitters with submissions or the creator of the challenge

#1549

Author: jmgasper

src/components/ChallengeEditor/ChallengeViewTabs/index.js

@@ -287,6 +287,7 @@ const ChallengeViewTabs = ({
           resources={allResources}
           canEditResource={canEditResource}
           deleteResource={deleteResource}
+          submissions={submissions}
         />
       )}
       {selectedTab === 2 && (

src/components/ChallengeEditor/Resources/index.js

@@ -62,28 +62,37 @@ export default class Resources extends React.Component {
         sort: ''
       },
       selectedTab: 0,
-      showDeleteResourceModal: null
+      showDeleteResourceModal: null,
+      exceptionHandlesDeleteList: {}
     }
 
     this.sortResources = this.sortResources.bind(this)
     this.getResourcesSortParam = this.getResourcesSortParam.bind(this)
     this.updateSortedResources = this.updateSortedResources.bind(this)
+    this.updateExceptionHandlesDelete = this.updateExceptionHandlesDelete.bind(this)
     this.onSortChange = this.onSortChange.bind(this)
     this.setSelectedTab = this.setSelectedTab.bind(this)
   }
 
   componentDidMount () {
     this.updateSortedResources()
+    this.updateExceptionHandlesDelete()
   }
 
   componentDidUpdate (prevProps) {
-    const { resources, resourcesSort } = this.props
+    const { resources, resourcesSort, submissions, challenge } = this.props
     if (
       !_.isEqual(prevProps.resources, resources) ||
       !_.isEqual(prevProps.resourcesSort, resourcesSort)
     ) {
       this.updateSortedResources()
     }
+    if (
+      !_.isEqual(prevProps.submissions, submissions) ||
+      !_.isEqual(prevProps.challenge, challenge)
+    ) {
+      this.updateExceptionHandlesDelete()
+    }
   }
   onSortChange (sort) {
     this.setState({
@@ -129,6 +138,20 @@ export default class Resources extends React.Component {
     this.setState({ sortedResources })
   }
 
+  /**
+   * Update exception handles delete
+   * Don't allow deletion of submitters who submitted, or creator of challenge
+   */
+  updateExceptionHandlesDelete () {
+    const { submissions, challenge } = this.props
+    const exceptionHandlesDeleteList = {}
+    exceptionHandlesDeleteList[challenge.createdBy] = true
+    _.forEach(submissions, (s) => {
+      exceptionHandlesDeleteList[s.createdBy] = true
+    })
+    this.setState({ exceptionHandlesDeleteList })
+  }
+
   /**
    * Sort array of registrant
    * @param {Array} resources array of registrant
@@ -186,7 +209,7 @@ export default class Resources extends React.Component {
     const { challenge, canEditResource, deleteResource } = this.props
     const { track } = challenge
 
-    const { sortedResources, selectedTab, showDeleteResourceModal } = this.state
+    const { sortedResources, selectedTab, showDeleteResourceModal, exceptionHandlesDeleteList } = this.state
 
     const { field, sort } = this.getResourcesSortParam()
     const revertSort = sort === 'desc' ? 'asc' : 'desc'
@@ -353,17 +376,18 @@ export default class Resources extends React.Component {
                       <span role='cell'>{formatDate(r.created)}</span>
                     </td>
 
-                    {canEditResource ? (<td className={cn(styles['col-8Table'], styles['col-bodyTable'])}>
-                      <button
-                        onClick={() => {
-                          this.setState({
-                            showDeleteResourceModal: r
-                          })
-                        }}
-                      >
-                        <ReactSVG path={assets(`${Trash}`)} />
-                      </button>
-                    </td>) : null}
+                    {(canEditResource && !exceptionHandlesDeleteList[r.memberHandle]) ? (
+                      <td className={cn(styles['col-8Table'], styles['col-bodyTable'])}>
+                        <button
+                          onClick={() => {
+                            this.setState({
+                              showDeleteResourceModal: r
+                            })
+                          }}
+                        >
+                          <ReactSVG path={assets(`${Trash}`)} />
+                        </button>
+                      </td>) : null}
                   </tr>
                 )
               })}
@@ -383,7 +407,8 @@ export default class Resources extends React.Component {
 Resources.defaultProps = {
   results: [],
   checkpointResults: {},
-  resourcesSort: {}
+  resourcesSort: {},
+  submissions: []
 }
 
 Resources.propTypes = {
@@ -404,6 +429,7 @@ Resources.propTypes = {
     type: PT.string,
     track: PT.string
   }).isRequired,
+  submissions: PT.arrayOf(PT.shape()),
   resources: PT.arrayOf(PT.shape()),
   resourcesSort: PT.shape({
     field: PT.string,