From 2f387afd8693d678d7a19c7939fcb453484053c3 Mon Sep 17 00:00:00 2001 From: Sukma Nugraha Date: Thu, 4 Jul 2019 18:45:54 +0700 Subject: [PATCH] Show proper error message when creating new project type or product category with same key as deleted one. --- src/routes/productCategories/create.js | 4 ++-- src/routes/projectTypes/create.js | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/routes/productCategories/create.js b/src/routes/productCategories/create.js index e80bc596..811c9fa7 100644 --- a/src/routes/productCategories/create.js +++ b/src/routes/productCategories/create.js @@ -41,10 +41,10 @@ module.exports = [ }); // Check if duplicated key - return models.ProductCategory.findById(req.body.param.key) + return models.ProductCategory.findById(req.body.param.key, { paranoid: false }) .then((existing) => { if (existing) { - const apiErr = new Error(`Product category already exists for key ${req.params.key}`); + const apiErr = new Error(`Product category already exists(may be deleted) for key "${req.body.param.key}"`); apiErr.status = 422; return Promise.reject(apiErr); } diff --git a/src/routes/projectTypes/create.js b/src/routes/projectTypes/create.js index 8e73e1ec..028f21bb 100644 --- a/src/routes/projectTypes/create.js +++ b/src/routes/projectTypes/create.js @@ -42,10 +42,10 @@ module.exports = [ }); // Check if duplicated key - return models.ProjectType.findById(req.body.param.key) + return models.ProjectType.findById(req.body.param.key, { paranoid: false }) .then((existing) => { if (existing) { - const apiErr = new Error(`Project type already exists for key ${req.params.key}`); + const apiErr = new Error(`Project type already exists(may be deleted) for key "${req.body.param.key}"`); apiErr.status = 422; return Promise.reject(apiErr); }