Project migration challenge

Author: coderReview

.babelrc

@@ -1,9 +1,9 @@
 {
-  "presets": ["es2015"],
-  "plugins": [
-    ["transform-runtime", {
-      "polyfill": false,
-      "regenerator": true
+  "presets": [
+    ["env", {
+      "targets": {
+        "node": "current"
+      }
     }]
   ]
 }

migrations/project_add_version_column.sql

@@ -0,0 +1,4 @@
+-- make sure to update existing projects to have this field set to "v2"
+ALTER TABLE projects ADD COLUMN "version" varchar(3) NOT NULL DEFAULT 'v2';
+-- make sure new projects from now on have "v3" as default value
+ALTER TABLE projects ALTER COLUMN "version" SET DEFAULT 'v3'

package.json

@@ -9,16 +9,16 @@
   "scripts": {
     "lint": "./node_modules/.bin/eslint .",
     "lint:fix": "./node_modules/.bin/eslint . --fix || true",
-    "build": "babel src -d dist --presets es2015",
+    "build": "babel src -d dist",
     "sync:db": "./node_modules/.bin/babel-node migrations/sync.js",
     "sync:es": "./node_modules/.bin/babel-node migrations/elasticsearch_sync.js",
     "migrate:es": "./node_modules/.bin/babel-node migrations/seedElasticsearchIndex.js",
     "prestart": "npm run -s build",
     "start": "node dist",
-    "start:dev": "NODE_ENV=development PORT=8001 nodemon -w src --exec \"babel-node src --presets es2015\" | ./node_modules/.bin/bunyan",
+    "start:dev": "NODE_ENV=development PORT=8001 nodemon -w src --exec \"babel-node src\" | ./node_modules/.bin/bunyan",
     "test": "NODE_ENV=test npm run lint && NODE_ENV=test npm run sync:es && NODE_ENV=test ./node_modules/.bin/istanbul cover ./node_modules/mocha/bin/_mocha -- --compilers js:babel-core/register $(find src -path '*spec.js*')",
     "test:watch": "NODE_ENV=test ./node_modules/.bin/mocha -w --compilers js:babel-core/register $(find src -path '*spec.js*')",
-    "seed": "babel-node src/tests/seed.js --presets es2015"
+    "seed": "babel-node src/tests/seed.js"
   },
   "repository": {
     "type": "git",
@@ -53,7 +53,7 @@
     "lodash": "^4.16.4",
     "method-override": "^2.3.9",
     "pg": "^4.5.5",
-    "pg-native": "^1.10.0",
+    "pg-native": "^1.10.1",
     "sequelize": "^3.23.0",
     "tc-core-library-js": "appirio-tech/tc-core-library-js.git#v2.3",
     "traverse": "^0.6.6",
@@ -63,9 +63,7 @@
     "babel-cli": "^6.9.0",
     "babel-core": "^6.11.4",
     "babel-eslint": "^7.1.1",
-    "babel-plugin-add-module-exports": "^0.2.1",
-    "babel-plugin-transform-runtime": "^6.23.0",
-    "babel-preset-es2015": "^6.9.0",
+    "babel-preset-env": "^1.7.0",
     "bunyan": "^1.8.1",
     "chai": "^3.5.0",
     "eslint": "^3.16.1",

postman.json

@@ -2905,6 +2905,104 @@
 					"response": []
 				}
 			]
+		},
+		{
+			"name": "Project upgrade",
+			"description": "Request to migrate projects.",
+			"item": [
+				{
+					"name": "Migrate project",
+					"request": {
+						"method": "POST",
+						"header": [
+							{
+								"key": "Authorization",
+								"value": "Bearer {{jwt-token}}"
+							},
+							{
+								"key": "Content-Type",
+								"value": "application/json"
+							}
+						],
+						"body": {
+							"mode": "raw",
+							"raw": "{\n\t\"param\": {\n\t\t\"targetVersion\": \"v3\",\n\t\t\"defaultProductTemplateId\": 3\n\t}\n}"
+						},
+						"url": "{{api-url}}/v4/projects/6/upgrade",
+						"description": ""
+					},
+					"response": []
+				},
+				{
+					"name": "Migrate project (completed)",
+					"request": {
+						"method": "POST",
+						"header": [
+							{
+								"key": "Authorization",
+								"value": "Bearer {{jwt-token}}"
+							},
+							{
+								"key": "Content-Type",
+								"value": "application/json"
+							}
+						],
+						"body": {
+							"mode": "raw",
+							"raw": "{\n\t\"param\": {\n\t\t\"targetVersion\": \"v3\",\n\t\t\"defaultProductTemplateId\": 3\n\t}\n}"
+						},
+						"url": "{{api-url}}/v4/projects/7/upgrade",
+						"description": ""
+					},
+					"response": []
+				},
+				{
+					"name": "Migrate project with phase name",
+					"request": {
+						"method": "POST",
+						"header": [
+							{
+								"key": "Authorization",
+								"value": "Bearer {{jwt-token}}"
+							},
+							{
+								"key": "Content-Type",
+								"value": "application/json"
+							}
+						],
+						"body": {
+							"mode": "raw",
+							"raw": "{\n\t\"param\": {\n\t\t\"targetVersion\": \"v3\",\n\t\t\"defaultProductTemplateId\": 3,\n\t\t\"phaseName\": \"Custom phase name\"\n\t}\n}"
+						},
+						"url": "{{api-url}}/v4/projects/6/upgrade",
+						"description": ""
+					},
+					"response": []
+				},
+				{
+					"name": "Migrate project with phase name (completed)",
+					"request": {
+						"method": "POST",
+						"header": [
+							{
+								"key": "Authorization",
+								"value": "Bearer {{jwt-token}}"
+							},
+							{
+								"key": "Content-Type",
+								"value": "application/json"
+							}
+						],
+						"body": {
+							"mode": "raw",
+							"raw": "{\n\t\"param\": {\n\t\t\"targetVersion\": \"v3\",\n\t\t\"defaultProductTemplateId\": 3,\n\t\t\"phaseName\": \"Custom phase name\"\n\t}\n}"
+						},
+						"url": "{{api-url}}/v4/projects/7/upgrade",
+						"description": ""
+					},
+					"response": []
+				}
+			]
 		}
 	]
-}
+}

src/models/project.js

@@ -41,6 +41,7 @@ module.exports = function defineProject(sequelize, DataTypes) {
     updatedAt: { type: DataTypes.DATE, defaultValue: DataTypes.NOW },
     createdBy: { type: DataTypes.INTEGER, allowNull: false },
     updatedBy: { type: DataTypes.INTEGER, allowNull: false },
+    version: { type: DataTypes.STRING(3), allowNull: false, defaultValue: 'v3' },
   }, {
     tableName: 'projects',
     timestamps: true,

src/routes/index.js

@@ -67,6 +67,9 @@ router.route('/v4/projects/:projectId(\\d+)/attachments/:id(\\d+)')
   .patch(require('./attachments/update'))
   .delete(require('./attachments/delete'));
 
+router.route('/v4/projects/:projectId(\\d+)/upgrade')
+  .post(require('./projectUpgrade/create'));
+
 router.route('/v4/projectTemplates')
   .post(require('./projectTemplates/create'))
   .get(require('./projectTemplates/list'));