Skip to content

Commit b217239

Browse files
author
Vikas Agarwal
committed
More configurable variables in invite email
1 parent 39e723f commit b217239

File tree

4 files changed

+26
-5
lines changed

4 files changed

+26
-5
lines changed

config/custom-environment-variables.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,5 +47,8 @@
4747
"AUTH0_AUDIENCE": "AUTH0_AUDIENCE",
4848
"TOKEN_CACHE_TIME" : "TOKEN_CACHE_TIME",
4949
"whitelistedOriginsForUserIdAuth": "WHITELISTED_ORIGINS_FOR_USERID_AUTH",
50-
"AUTH0_PROXY_SERVER_URL" : "AUTH0_PROXY_SERVER_URL"
50+
"AUTH0_PROXY_SERVER_URL" : "AUTH0_PROXY_SERVER_URL",
51+
"connectUrl": "CONNECT_URL",
52+
"accountsAppUrl": "ACCOUNTS_APP_URL",
53+
"inviteEmailSubject": "INVITE_EMAIL_SUBJECT"
5154
}

config/default.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,8 @@
5454
"AUTH0_PROXY_SERVER_URL" : "",
5555
"EMAIL_INVITE_FROM_NAME":"Topcoder",
5656
"EMAIL_INVITE_FROM_EMAIL":"noreply@connect.topcoder.com",
57-
"CONNECT_URL":"https://connect.topcoder-dev.com"
57+
"inviteEmailSubject": "You are invited to Topcoder",
58+
"connectUrl":"https://connect.topcoder-dev.com",
59+
"accountsAppUrl": "https://accounts.topcoder-dev.com"
5860

5961
}

deploy.sh

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -152,6 +152,14 @@ make_task_def(){
152152
"name": "CONNECT_PROJECTS_URL",
153153
"value": "%s"
154154
},
155+
{
156+
"name": "CONNECT_URL",
157+
"value": "%s"
158+
},
159+
{
160+
"name": "ACCOUNTS_APP_URL",
161+
"value": "%s"
162+
},
155163
{
156164
"name": "SEGMENT_ANALYTICS_KEY",
157165
"value": "%s"
@@ -203,6 +211,10 @@ make_task_def(){
203211
{
204212
"name": "EMAIL_INVITE_FROM_EMAIL",
205213
"value": "%s"
214+
},
215+
{
216+
"name": "INVITE_EMAIL_SUBJECT",
217+
"value": "%s"
206218
}
207219
],
208220
"portMappings": [
@@ -238,6 +250,8 @@ make_task_def(){
238250
DIRECT_PROJECT_SERVICE_ENDPOINT=$(eval "echo \$${ENV}_DIRECT_PROJECT_SERVICE_ENDPOINT")
239251
FILE_SERVICE_ENDPOINT=$(eval "echo \$${ENV}_FILE_SERVICE_ENDPOINT")
240252
CONNECT_PROJECTS_URL=$(eval "echo \$${ENV}_CONNECT_PROJECTS_URL")
253+
CONNECT_URL=$(eval "echo \$${ENV}_CONNECT_URL")
254+
ACCOUNTS_APP_URL=$(eval "echo \$${ENV}_ACCOUNTS_APP_URL")
241255
SEGMENT_ANALYTICS_KEY=$(eval "echo \$${ENV}_SEGMENT_ANALYTICS_KEY")
242256
MESSAGE_SERVICE_URL=$(eval "echo \$${ENV}_MESSAGE_SERVICE_URL")
243257
if [ "$ENV" = "PROD" ]; then
@@ -258,13 +272,13 @@ make_task_def(){
258272
KAFKA_CLIENT_CERT_KEY=$(eval "echo \$${ENV}_KAFKA_CLIENT_CERT_KEY")
259273
KAFKA_GROUP_ID=$(eval "echo \$${ENV}_KAFKA_GROUP_ID")
260274
KAFKA_URL=$(eval "echo \$${ENV}_KAFKA_URL")
261-
AUTH0_PROXY_SERVER_URL=$(eval "echo \$${ENV}_AUTH0_PROXY_SERVER_URL")
262275

263276
AUTH0_PROXY_SERVER_URL=$(eval "echo \$${ENV}_AUTH0_PROXY_SERVER_URL")
264277
EMAIL_INVITE_FROM_NAME=$(eval "echo \$${ENV}_EMAIL_INVITE_FROM_NAME")
265278
EMAIL_INVITE_FROM_EMAIL=$(eval "echo \$${ENV}_EMAIL_INVITE_FROM_EMAIL")
279+
INVITE_EMAIL_SUBJECT=$(eval "echo \$${ENV}_INVITE_EMAIL_SUBJECT")
266280

267-
task_def=$(printf "$task_template" $1 $ACCOUNT_ID $ACCOUNT_ID $AWS_ECS_CONTAINER_NAME $ACCOUNT_ID $AWS_REGION $AWS_REPOSITORY $CIRCLE_SHA1 $2 $3 $4 $NODE_ENV $ENABLE_FILE_UPLOAD $LOG_LEVEL $CAPTURE_LOGS $LOGENTRIES_TOKEN $API_VERSION $AWS_REGION $AUTH_DOMAIN $AUTH_SECRET $VALID_ISSUERS $DB_MASTER_URL $MEMBER_SERVICE_ENDPOINT $IDENTITY_SERVICE_ENDPOINT $BUS_API_URL $MESSAGE_SERVICE_URL $SYSTEM_USER_CLIENT_ID $SYSTEM_USER_CLIENT_SECRET $PROJECTS_ES_URL $PROJECTS_ES_INDEX_NAME $RABBITMQ_URL $DIRECT_PROJECT_SERVICE_ENDPOINT $FILE_SERVICE_ENDPOINT $CONNECT_PROJECTS_URL $SEGMENT_ANALYTICS_KEY "$AUTH0_URL" "$AUTH0_AUDIENCE" $AUTH0_CLIENT_ID "$AUTH0_CLIENT_SECRET" $TOKEN_CACHE_TIME "$KAFKA_CLIENT_CERT" "$KAFKA_CLIENT_CERT_KEY" $KAFKA_GROUP_ID $KAFKA_URL "$AUTH0_PROXY_SERVER_URL" "$EMAIL_INVITE_FROM_NAME" "$EMAIL_INVITE_FROM_EMAIL" $PORT $PORT $AWS_ECS_CLUSTER $AWS_REGION $NODE_ENV)
281+
task_def=$(printf "$task_template" $1 $ACCOUNT_ID $ACCOUNT_ID $AWS_ECS_CONTAINER_NAME $ACCOUNT_ID $AWS_REGION $AWS_REPOSITORY $CIRCLE_SHA1 $2 $3 $4 $NODE_ENV $ENABLE_FILE_UPLOAD $LOG_LEVEL $CAPTURE_LOGS $LOGENTRIES_TOKEN $API_VERSION $AWS_REGION $AUTH_DOMAIN $AUTH_SECRET $VALID_ISSUERS $DB_MASTER_URL $MEMBER_SERVICE_ENDPOINT $IDENTITY_SERVICE_ENDPOINT $BUS_API_URL $MESSAGE_SERVICE_URL $SYSTEM_USER_CLIENT_ID $SYSTEM_USER_CLIENT_SECRET $PROJECTS_ES_URL $PROJECTS_ES_INDEX_NAME $RABBITMQ_URL $DIRECT_PROJECT_SERVICE_ENDPOINT $FILE_SERVICE_ENDPOINT $CONNECT_PROJECTS_URL $CONNECT_URL $ACCOUNTS_APP_URL $SEGMENT_ANALYTICS_KEY "$AUTH0_URL" "$AUTH0_AUDIENCE" $AUTH0_CLIENT_ID "$AUTH0_CLIENT_SECRET" $TOKEN_CACHE_TIME "$KAFKA_CLIENT_CERT" "$KAFKA_CLIENT_CERT_KEY" $KAFKA_GROUP_ID $KAFKA_URL "$AUTH0_PROXY_SERVER_URL" "$EMAIL_INVITE_FROM_NAME" "$EMAIL_INVITE_FROM_EMAIL" $INVITE_EMAIL_SUBJECT $PORT $PORT $AWS_ECS_CLUSTER $AWS_REGION $NODE_ENV)
268282
}
269283

270284
push_ecr_image(){

src/routes/projectMemberInvites/create.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,9 @@ module.exports = [
155155
createEvent(emailEventType,
156156
{
157157
data: {
158-
connectURL: config.get('CONNECT_URL'),
158+
connectURL: config.get('connectUrl'),
159+
accountsAppURL: config.get('accountsAppUrl'),
160+
subject: config.get("inviteEmailSubject"),
159161
projects: [
160162
{
161163
name: _project.name,

0 commit comments

Comments
 (0)