config based file upload in dev env

Author: Vikas Agarwal

config/custom-environment-variables.json

@@ -4,6 +4,7 @@
   "logLevel": "LOG_LEVEL",
   "version": "APP_VERSION",
   "captureLogs": "CAPTURE_LOGS",
+  "enableFileUpload": "ENABLE_FILE_UPLOAD",
   "logentriesToken": "LOGENTRIES_TOKEN",
   "elasticsearchConfig": {
     "host": "PROJECTS_ES_URL",

config/default.json

@@ -4,6 +4,7 @@
   "logLevel": "info",
   "version": "v4",
   "captureLogs": "false",
+  "enableFileUpload": "true",
   "logentriesToken": "",
   "rabbitmqURL": "",
   "pubsubQueueName": "project.service",

deploy.sh

@@ -61,6 +61,10 @@ make_task_def(){
           "name": "NODE_ENV",
           "value": "%s"
         },
+        {
+          "name": "ENABLE_FILE_UPLOAD",
+          "value": "%s"
+        },
         {
           "name": "LOG_LEVEL",
           "value": "%s"
@@ -236,6 +240,7 @@ make_task_def(){
   fi
   echo "NODE_ENV"
   echo $NODE_ENV
+  ENABLE_FILE_UPLOAD=$(eval "echo \$${ENV}_ENABLE_FILE_UPLOAD")
 
   AUTH0_URL=$(eval "echo \$${ENV}_AUTH0_URL")
   AUTH0_AUDIENCE=$(eval "echo \$${ENV}_AUTH0_AUDIENCE")
@@ -248,7 +253,7 @@ make_task_def(){
   KAFKA_URL=$(eval "echo \$${ENV}_KAFKA_URL")
 
 
-  task_def=$(printf "$task_template" $family $ACCOUNT_ID $AWS_ECS_CONTAINER_NAME $ACCOUNT_ID $AWS_REGION $AWS_REPOSITORY $CIRCLE_SHA1 $NODE_ENV $LOG_LEVEL $CAPTURE_LOGS $LOGENTRIES_TOKEN $API_VERSION $AWS_REGION $AWS_ACCESS_KEY_ID $AWS_SECRET_ACCESS_KEY $AUTH_DOMAIN $AUTH_SECRET $VALID_ISSUERS $DB_MASTER_URL $MEMBER_SERVICE_ENDPOINT $IDENTITY_SERVICE_ENDPOINT $BUS_API_URL $MESSAGE_SERVICE_URL $SYSTEM_USER_CLIENT_ID $SYSTEM_USER_CLIENT_SECRET $PROJECTS_ES_URL $PROJECTS_ES_INDEX_NAME $RABBITMQ_URL $DIRECT_PROJECT_SERVICE_ENDPOINT $FILE_SERVICE_ENDPOINT $CONNECT_PROJECTS_URL $SEGMENT_ANALYTICS_KEY "$AUTH0_URL" "$AUTH0_AUDIENCE" $AUTH0_CLIENT_ID "$AUTH0_CLIENT_SECRET" $TOKEN_CACHE_TIME "$KAFKA_CLIENT_CERT" "$KAFKA_CLIENT_CERT_KEY" $KAFKA_GROUP_ID $KAFKA_URL $PORT $PORT $AWS_ECS_CLUSTER $AWS_REGION $NODE_ENV)
+  task_def=$(printf "$task_template" $family $ACCOUNT_ID $AWS_ECS_CONTAINER_NAME $ACCOUNT_ID $AWS_REGION $AWS_REPOSITORY $CIRCLE_SHA1 $NODE_ENV $ENABLE_FILE_UPLOAD $LOG_LEVEL $CAPTURE_LOGS $LOGENTRIES_TOKEN $API_VERSION $AWS_REGION $AWS_ACCESS_KEY_ID $AWS_SECRET_ACCESS_KEY $AUTH_DOMAIN $AUTH_SECRET $VALID_ISSUERS $DB_MASTER_URL $MEMBER_SERVICE_ENDPOINT $IDENTITY_SERVICE_ENDPOINT $BUS_API_URL $MESSAGE_SERVICE_URL $SYSTEM_USER_CLIENT_ID $SYSTEM_USER_CLIENT_SECRET $PROJECTS_ES_URL $PROJECTS_ES_INDEX_NAME $RABBITMQ_URL $DIRECT_PROJECT_SERVICE_ENDPOINT $FILE_SERVICE_ENDPOINT $CONNECT_PROJECTS_URL $SEGMENT_ANALYTICS_KEY "$AUTH0_URL" "$AUTH0_AUDIENCE" $AUTH0_CLIENT_ID "$AUTH0_CLIENT_SECRET" $TOKEN_CACHE_TIME "$KAFKA_CLIENT_CERT" "$KAFKA_CLIENT_CERT_KEY" $KAFKA_GROUP_ID $KAFKA_URL $PORT $PORT $AWS_ECS_CLUSTER $AWS_REGION $NODE_ENV)
 }
 
 push_ecr_image(){

src/routes/attachments/create.js

@@ -67,7 +67,7 @@ module.exports = [
     }
 
     const fileTransferPromise = new Promise((accept, reject) => {
-      if (process.env.NODE_ENV !== 'development') {
+      if (process.env.NODE_ENV !== 'development' || config.get('enableFileUpload') === 'true') {
         // get pre-signed Url
         req.log.debug('requesting presigned Url');
         httpClient.post(`${fileServiceUrl}uploadurl/`, {