Skip to content

Commit a79d013

Browse files
author
Parth Shah
committed
fixing event handler error
1 parent ee65a9f commit a79d013

File tree

3 files changed

+9
-26
lines changed

3 files changed

+9
-26
lines changed

src/events/analytics.js

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,7 @@
11
import Analytics from 'analytics-node';
22
import _ from 'lodash';
33
import 'config';
4-
import {
5-
EVENT,
6-
PROJECT_STATUS,
7-
} from '../constants';
4+
import { EVENT, PROJECT_STATUS } from '../constants';
85

96
const PROJECT_CREATED = 'Project Created';
107
const PROJECT_SUBMITTED = 'Project Submitted';

src/events/index.js

Lines changed: 4 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,10 @@
11

2-
import {
3-
EVENT,
4-
} from '../constants';
5-
import {
6-
projectCreatedHandler,
7-
} from './projects';
8-
import {
9-
projectMemberAddedHandler,
10-
projectMemberRemovedHandler,
11-
} from './projectMembers';
2+
import { EVENT } from '../constants';
3+
import { projectCreatedHandler } from './projects';
4+
import { projectMemberAddedHandler, projectMemberRemovedHandler } from './projectMembers';
125

13-
const handlers = {
6+
export default {
147
[EVENT.ROUTING_KEY.PROJECT_DRAFT_CREATED]: projectCreatedHandler,
158
[EVENT.ROUTING_KEY.PROJECT_MEMBER_ADDED]: projectMemberAddedHandler,
169
[EVENT.ROUTING_KEY.PROJECT_MEMBER_REMOVED]: projectMemberRemovedHandler,
1710
};
18-
19-
export default {
20-
handlers,
21-
};

src/services/rabbitmq.js

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,16 @@
11
/* globals Promise */
22
import _ from 'lodash';
33
import amqplib from 'amqplib';
4-
import { EventEmitter } from 'events';
5-
import { handlers as msgHandlers } from '../events';
4+
import handlers from '../events';
65

7-
module.exports = class RabbitMQService extends EventEmitter {
6+
module.exports = class RabbitMQService {
87

98
/**
109
* constructor
1110
* @param {Object} app express app Object
1211
* @param {Object} logger logger object
1312
*/
1413
constructor(app, logger) {
15-
super();
16-
EventEmitter.call(this);
1714
this.app = app;
1815
this.logger = logger;
1916
this.subscriberCxn = null;
@@ -87,7 +84,7 @@ module.exports = class RabbitMQService extends EventEmitter {
8784
self.subscriberQ = qok.queue;
8885
// bindings for the queue
8986
// all these keys/bindings should be routed to the same queue
90-
const bindings = _.keys(msgHandlers);
87+
const bindings = _.keys(handlers);
9188
self.logger.debug('Adding bindings: ', bindings);
9289
const bindingPromises = _.map(bindings, rk =>
9390
channel.bindQueue(self.subscriberQ, self.exchangeName, rk));
@@ -101,7 +98,7 @@ module.exports = class RabbitMQService extends EventEmitter {
10198
requestId: msg.properties.correlationId,
10299
});
103100
cLogger.debug('Received Message', key, msg.fields);
104-
const handler = msgHandlers[key];
101+
const handler = handlers[key];
105102
if (!_.isFunction(handler)) {
106103
cLogger.error(`Unknown message type: ${key}, NACKing... `);
107104
// channel.nack(msg, false, false)

0 commit comments

Comments
 (0)