Skip to content

Commit a1c98b3

Browse files
maxceemmaxceem
committed
refactor: clarify unit test descriptions
1 parent e34af57 commit a1c98b3

File tree

2 files changed

+21
-22
lines changed

2 files changed

+21
-22
lines changed

‎src/routes/projects/get.spec.js

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -378,7 +378,7 @@ describe('GET Project', () => {
378378
describe('URL Query fields', () => {
379379
it('should not return "email" for project members when "fields" query param is not defined (to non-admin users)', (done) => {
380380
request(server)
381-
.get(`/v5/projects/${project1.id}?fields=members.handle`)
381+
.get(`/v5/projects/${project1.id}`)
382382
.set({
383383
Authorization: `Bearer ${testUtil.jwts.member}`,
384384
})
@@ -397,7 +397,7 @@ describe('GET Project', () => {
397397
});
398398
});
399399

400-
it('should not return "email" for project members even if it\'s defined in "fields" query param (to non-admin users)', (done) => {
400+
it('should not return "email" for project members even if it\'s listed in "fields" query param (to non-admin users)', (done) => {
401401
request(server)
402402
.get(`/v5/projects/${project1.id}?fields=members.email,members.handle`)
403403
.set({
@@ -441,7 +441,7 @@ describe('GET Project', () => {
441441
});
442442
});
443443

444-
it('should not return "email" for project members when "fields" query param is not defined (to admin users)', (done) => {
444+
it('should not return "email" for project members if it\'s not listed in "fields" query param (to admin users)', (done) => {
445445
request(server)
446446
.get(`/v5/projects/${project1.id}?fields=description,members.id`)
447447
.set({
@@ -462,7 +462,7 @@ describe('GET Project', () => {
462462
});
463463
});
464464

465-
it('should return "email" for project members if it\'s defined in "fields" query param (to admin users', (done) => {
465+
it('should return "email" for project members if it\'s listed in "fields" query param (to admin users)', (done) => {
466466
request(server)
467467
.get(`/v5/projects/${project1.id}?fields=description,members.id,members.email`)
468468
.set({
@@ -484,8 +484,7 @@ describe('GET Project', () => {
484484
});
485485
});
486486

487-
488-
it('should only return "id" field, when it\'s defined in "fields" query param', (done) => {
487+
it('should only return "id" field, when it\'s the only field listed in "fields" query param', (done) => {
489488
request(server)
490489
.get(`/v5/projects/${project1.id}?fields=id`)
491490
.set({
@@ -506,7 +505,7 @@ describe('GET Project', () => {
506505
});
507506
});
508507

509-
it('should only return "invites.userId" field, when it\'s defined in "fields" query param', (done) => {
508+
it('should only return "invites.userId" field, when it\'s the only field listed in "fields" query param', (done) => {
510509
request(server)
511510
.get(`/v5/projects/${project1.id}?fields=invites.userId`)
512511
.set({
@@ -527,7 +526,7 @@ describe('GET Project', () => {
527526
});
528527
});
529528

530-
it('should only return "members.role" field, when it\'s defined in "fields" query param', (done) => {
529+
it('should only return "members.role" field, when it\'s the only field listed in "fields" query param', (done) => {
531530
request(server)
532531
.get(`/v5/projects/${project1.id}?fields=members.role`)
533532
.set({
@@ -548,7 +547,7 @@ describe('GET Project', () => {
548547
});
549548
});
550549

551-
it('should only return "attachments.title" field, when it\'s defined in "fields" query param', (done) => {
550+
it('should only return "attachments.title" field, when it\'s the only field listed in "fields" query param', (done) => {
552551
request(server)
553552
.get(`/v5/projects/${project1.id}?fields=attachments.title`)
554553
.set({
@@ -569,7 +568,7 @@ describe('GET Project', () => {
569568
});
570569
});
571570

572-
it('should only return "phases.name" field, when it\'s defined in "fields" query param', (done) => {
571+
it('should only return "phases.name" field, when it\'s the only field listed in "fields" query param', (done) => {
573572
request(server)
574573
.get(`/v5/projects/${project1.id}?fields=phases.name`)
575574
.set({
@@ -590,9 +589,9 @@ describe('GET Project', () => {
590589
});
591590
});
592591

593-
it('should only return "phases.products.name" field, when it\'s defined in "fields" query param and "phases" is also defined', (done) => {
592+
it('should only return "phases.products.name" field, when it\'s the only field listed in "fields" query param', (done) => {
594593
request(server)
595-
.get(`/v5/projects/${project1.id}?fields=phases.products.name,phases.name`)
594+
.get(`/v5/projects/${project1.id}?fields=phases.products.name`)
596595
.set({
597596
Authorization: `Bearer ${testUtil.jwts.admin}`,
598597
})

‎src/routes/projects/list.spec.js

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1118,7 +1118,7 @@ describe('LIST Project', () => {
11181118
});
11191119

11201120

1121-
it('should not return "email" for project members even if it\'s defined in "fields" query param (to non-admin users)', (done) => {
1121+
it('should not return "email" for project members even if it\'s listed in "fields" query param (to non-admin users)', (done) => {
11221122
request(server)
11231123
.get('/v5/projects/?fields=members.email,members.id')
11241124
.set({
@@ -1163,7 +1163,7 @@ describe('LIST Project', () => {
11631163
});
11641164
});
11651165

1166-
it('should not return "email" for project members when "fields" query param is not defined (to admin users)', (done) => {
1166+
it('should not return "email" for project members when it is not listed in "fields" query param (to admin users)', (done) => {
11671167
request(server)
11681168
.get('/v5/projects/?fields=description,members.id')
11691169
.set({
@@ -1186,7 +1186,7 @@ describe('LIST Project', () => {
11861186
});
11871187

11881188

1189-
it('should return "email" for project members if it\'s defined in "fields" query param (to admin users', (done) => {
1189+
it('should return "email" for project members if it\'s listed in "fields" query param (to admin users)', (done) => {
11901190
request(server)
11911191
.get('/v5/projects/?fields=description,members.id,members.email')
11921192
.set({
@@ -1209,7 +1209,7 @@ describe('LIST Project', () => {
12091209
});
12101210
});
12111211

1212-
it('should only return "id" field, when it\'s defined in "fields" query param', (done) => {
1212+
it('should only return "id" field, when it\'s the only fields listed in "fields" query param', (done) => {
12131213
request(server)
12141214
.get('/v5/projects/?fields=id')
12151215
.set({
@@ -1230,7 +1230,7 @@ describe('LIST Project', () => {
12301230
});
12311231
});
12321232

1233-
it('should only return "invites.userId" field, when it\'s defined in "fields" query param', (done) => {
1233+
it('should only return "invites.userId" field, when it\'s the only field listed in "fields" query param', (done) => {
12341234
request(server)
12351235
.get('/v5/projects/?fields=invites.userId')
12361236
.set({
@@ -1251,7 +1251,7 @@ describe('LIST Project', () => {
12511251
});
12521252
});
12531253

1254-
it('should only return "members.role" field, when it\'s defined in "fields" query param', (done) => {
1254+
it('should only return "members.role" field, when it\'s the only field listed in "fields" query param', (done) => {
12551255
request(server)
12561256
.get('/v5/projects/?fields=members.role')
12571257
.set({
@@ -1272,7 +1272,7 @@ describe('LIST Project', () => {
12721272
});
12731273
});
12741274

1275-
it('should only return "attachments.title" field, when it\'s defined in "fields" query param', (done) => {
1275+
it('should only return "attachments.title" field, when it\'s the only field listed in "fields" query param', (done) => {
12761276
request(server)
12771277
.get('/v5/projects/?fields=attachments.title')
12781278
.set({
@@ -1293,7 +1293,7 @@ describe('LIST Project', () => {
12931293
});
12941294
});
12951295

1296-
it('should only return "phases.name" field, when it\'s defined in "fields" query param', (done) => {
1296+
it('should only return "phases.name" field, when it\'s the only field listed in "fields" query param', (done) => {
12971297
request(server)
12981298
.get('/v5/projects/?fields=phases.name')
12991299
.set({
@@ -1315,9 +1315,9 @@ describe('LIST Project', () => {
13151315
});
13161316
});
13171317

1318-
it('should only return "phases.products.name" field, when it\'s defined in "fields" query param and "phases" is also defined', (done) => {
1318+
it('should only return "phases.products.name" field, when it\'s the only field listed in "fields" query param', (done) => {
13191319
request(server)
1320-
.get('/v5/projects/?fields=phases.products.name,phases.name')
1320+
.get('/v5/projects/?fields=phases.products.name')
13211321
.set({
13221322
Authorization: `Bearer ${testUtil.jwts.admin}`,
13231323
})

0 commit comments

Comments
 (0)