updating lint config

Author: Parth Shah

.eslintignore

@@ -0,0 +1,7 @@
+config/local.js
+config/sample.local.js
+node_modules
+dist
+.ebextensions
+.elasticbeanstalk
+coverage

.eslintrc

@@ -1,5 +1,5 @@
 {
-  "extends": "airbnb",
+  "extends": "airbnb-base",
   "parser": "babel-eslint",
   "env": {
     "browser": false,
@@ -8,6 +8,7 @@
     "mocha": true
   },
   "rules": {
+    "import/no-extraneous-dependencies": ["error", {"devDependencies": ["**/*.test.js", "**/*.spec.js"]}],
     "valid-jsdoc": ["error", {
       "requireReturn": true,
       "requireReturnType": true,

config/sample.local.js

@@ -1,34 +1,34 @@
 // force using test.json for unit tests
 
-var config
+let config;
 if (process.env.NODE_ENV === 'test') {
-  config = require('./test.json')
+  config = require('./test.json');
 } else {
   config = {
-      "authSecret": "secret",
-      "logLevel": "debug",
-      "captureLogs": "false",
-      "logentriesToken": "",
-      "rabbitmqURL": "amqp://dockerhost:5672",
-      "fileServiceEndpoint": "https://api.topcoder-dev.com/v3/files/",
-      "topicServiceEndpoint": "https://api.topcoder-dev.com/v4/topics/",
-      "directProjectServiceEndpoint": "https://api.topcoder-dev.com/v3/direct",
-      "userServiceUrl": "https://api.topcoder-dev.com/v3/users",
-      "connectProjectsUrl": "https://connect.topcoder-dev.com/projects/",
-      "salesforceLead" : {
-        "webToLeadUrl": 'https://www.salesforce.com/servlet/servlet.WebToLead?encoding=UTF-8',
-        "orgId": "00D2C0000000dO6",
-        "projectNameFieldId": "title",
-        "projectDescFieldId": "description",
-        "projectLinkFieldId": "URL",
-        "projectIdFieldId"  : "00N2C000000Vxxx"
-      },
-      "dbConfig": {
-          "masterUrl": "postgres://coder:mysecretpassword@dockerhost:5432/projectsdb",
-          "maxPoolSize": 50,
-          "minPoolSize": 4,
-          "idleTimeout": 1000
-      }
-  }
+    authSecret: 'secret',
+    logLevel: 'debug',
+    captureLogs: 'false',
+    logentriesToken: '',
+    rabbitmqURL: 'amqp://dockerhost:5672',
+    fileServiceEndpoint: 'https://api.topcoder-dev.com/v3/files/',
+    topicServiceEndpoint: 'https://api.topcoder-dev.com/v4/topics/',
+    directProjectServiceEndpoint: 'https://api.topcoder-dev.com/v3/direct',
+    userServiceUrl: 'https://api.topcoder-dev.com/v3/users',
+    connectProjectsUrl: 'https://connect.topcoder-dev.com/projects/',
+    salesforceLead: {
+      webToLeadUrl: 'https://www.salesforce.com/servlet/servlet.WebToLead?encoding=UTF-8',
+      orgId: '00D2C0000000dO6',
+      projectNameFieldId: 'title',
+      projectDescFieldId: 'description',
+      projectLinkFieldId: 'URL',
+      projectIdFieldId: '00N2C000000Vxxx',
+    },
+    dbConfig: {
+      masterUrl: 'postgres://coder:mysecretpassword@dockerhost:5432/projectsdb',
+      maxPoolSize: 50,
+      minPoolSize: 4,
+      idleTimeout: 1000,
+    },
+  };
 }
-module.exports = config
+module.exports = config;

migrations/sync.js

@@ -1,4 +1,4 @@
-'use strict'
+
 
 /**
  * Sync the database models to db tables.
@@ -12,9 +12,9 @@
 
 require('./dist/models').default.sequelize.sync({ force: true })
   .then(() => {
-    console.log('Database synced successfully')
-    process.exit()
+    console.log('Database synced successfully');
+    process.exit();
   }).catch((err) => {
-    console.error('Error syncing database', err)
-    process.exit(1)
-  })
+    console.error('Error syncing database', err);
+    process.exit(1);
+  });

newrelic.js

@@ -9,7 +9,8 @@
   "scripts": {
     "build": "babel src -d dist --presets es2015",
     "sync": "node migrations/sync.js",
-    "lint": "./node_modules/.bin/eslint src",
+    "lint": "./node_modules/.bin/eslint .",
+    "lint:fix": "./node_modules/.bin/eslint . --fix || true",
     "prestart": "npm run -s build",
     "start": "node dist",
     "start:dev": "NODE_ENV=local PORT=8001 nodemon -w src --exec \"babel-node src --presets es2015\" | ./node_modules/.bin/bunyan",
@@ -43,7 +44,6 @@
     "express-validation": "^0.6.0",
     "joi": "^8.0.5",
     "lodash": "^4.16.4",
-    "newrelic": "^1.27.2",
     "pg": "^4.5.5",
     "pg-native": "^1.10.0",
     "sequelize": "^3.23.0",
@@ -57,11 +57,9 @@
     "babel-preset-es2015": "^6.9.0",
     "bunyan": "^1.8.1",
     "chai": "^3.5.0",
-    "eslint": "^3.2.2",
-    "eslint-config-airbnb": "^14.1.0",
+    "eslint": "^3.16.1",
+    "eslint-config-airbnb-base": "^11.1.0",
     "eslint-plugin-import": "^2.2.0",
-    "eslint-plugin-jsx-a11y": "^4.0.0",
-    "eslint-plugin-react": "^6.10.0",
     "istanbul": "^1.0.0-alpha.2",
     "mocha": "^2.5.3",
     "nodemon": "^1.9.1",

package.json

@@ -1,16 +1,11 @@
 
-
-import models from './models';
-
-// include newrelic
-if (process.env.NODE_ENV !== 'test' && process.env.NODE_ENV !== 'local') {
-  require('newrelic');
-}
-
 const app = require('./app');
+const coreLib = require('tc-core-library-js');
+const expressListRoutes = require('express-list-routes');
 
 /**
  * Handle server shutdown gracefully
+ * @returns {undefined}
  */
 function gracefulShutdown() {
   app.services.pubsub.disconnect()
@@ -36,9 +31,9 @@ const port = process.env.PORT || 3000; // used to create, sign, and verify token
 
 const server = app.listen(port, () => {
   app.logger.info('Starting server on PORT: %d', port);
-  const authz = require('tc-core-library-js').Authorizer;
+  const authz = coreLib.Authorizer;
   app.logger.info('Registered Policies', authz.getRegisteredPolicies());
-  require('express-list-routes')({ prefix: '', spacer: 7 }, 'APIs:', app.routerRef);
+  expressListRoutes({ prefix: '', spacer: 7 }, 'APIs:', app.routerRef);
 });
 
 module.exports = server;